[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
pull_requests: +11101, 11102, 11103

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
pull_requests: +11101, 11102

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
pull_requests: +11101

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Jesús Cea Avión]

Changes by Jesús Cea Avión :


--
superseder:  -> mock_open() should allow reading binary data

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Roundup Robot]

Roundup Robot added the comment:

New changeset 684b75600fa9 by Michael Foord in branch 'default':
Closes issue 17467. Add readline and readlines support to 
unittest.mock.mock_open
http://hg.python.org/cpython/rev/684b75600fa9

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Toshio Kuratomi]

Toshio Kuratomi added the comment:

3rd version of the patch.

* Added some documentation to untitest.mock.rst
* Changed the code so that read, readline, and readlines all deplete the same 
copy of read_data.

--
Added file: http://bugs.python.org/file29484/01000-mock_open-methods.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Michael Foord]

Changes by Michael Foord :


--
assignee:  -> michael.foord
keywords: +needs review
nosy: +michael.foord
stage:  -> patch review
type:  -> enhancement
versions: +Python 3.4 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Toshio Kuratomi]

Toshio Kuratomi added the comment:

Updated patch that includes unittests and fixes readlines() newline behaviour.

--
Added file: http://bugs.python.org/file29479/01000-mock_open-methods.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17467] Enhancement: give mock_open readline() and readlines() methods

[Toshio Kuratomi]

New submission from Toshio Kuratomi:

unittest.mock provides a mock_open convenience function[1].  The convenience 
function handled file.read() but does not handle file.readline() or 
file.readlines().  I'll attach a patch that adds support for both of these 
methods.

[1]: http://docs.python.org/3/library/unittest.mock.html#mock-open

--
files: python3-mock_open-methods.patch
keywords: patch
messages: 184512
nosy: a.badger
priority: normal
severity: normal
status: open
title: Enhancement: give mock_open readline() and readlines() methods
versions: Python 3.3
Added file: http://bugs.python.org/file29454/python3-mock_open-methods.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com