[issue17596] mingw: add wincrypt.h in Python/random.c

[Martin Panter]

Martin Panter added the comment:

For the record, the first error without this patch is

../Python/random.c:26:1: error: unknown type name 'HCRYPTPROV'

According to 
,
 the header to use is , but we use lowercase  to avoid 
a problem with case sensitivity.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17596] mingw: add wincrypt.h in Python/random.c

[Roundup Robot]

Roundup Robot added the comment:

New changeset 11ed7c49f5df by Martin Panter in branch 'default':
Issue #17596: MINGW: add wincrypt.h in Python/random.c
https://hg.python.org/cpython/rev/11ed7c49f5df

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17596] mingw: add wincrypt.h in Python/random.c

[Martin Panter]

Martin Panter added the comment:

I think this one should be fairly safe; any breakage should be pretty obvious 
by watching the buildbots.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17596] mingw: add wincrypt.h in Python/random.c

[Martin Panter]

Martin Panter added the comment:

Yes I would tend to think including  would be harmless on Windows, 
but I don’t have a native Windows to try it out on. Here is a proposed patch 
anyway. It would be good for someone to be able to confirm it doesn’t break the 
normal Windows build.

--
components: +Windows
nosy: +Alex.Willmer, martin.panter, paul.moore, steve.dower, tim.golden, 
zach.ware
stage:  -> patch review
versions: +Python 3.6 -Python 3.4
Added file: http://bugs.python.org/file42111/MINGW-wincrypt.v3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17596] mingw: add wincrypt.h in Python/random.c

[Roumen Petrov]

Changes by Roumen Petrov bugtr...@roumenpetrov.info:


Added file: 
http://bugs.python.org/file36220/0006-MINGW-add-wincrypt.h-in-Python-random.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17596
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17596] mingw: add wincrypt.h in Python/random.c

[Roumen Petrov]

New submission from Roumen Petrov:

split of issue3871

--
components: Build, Cross-Build
files: 0007-MINGW-add-wincrypt.h-in-Python-random.c.patch
keywords: patch
messages: 185656
nosy: rpetrov
priority: normal
severity: normal
status: open
title: mingw: add wincrypt.h in Python/random.c
type: enhancement
versions: Python 3.4
Added file: 
http://bugs.python.org/file29629/0007-MINGW-add-wincrypt.h-in-Python-random.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17596
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17596] mingw: add wincrypt.h in Python/random.c

[Antoine Pitrou]

Antoine Pitrou added the comment:

Why the #ifdef __MINGW32__? I suppose the include is harmless anyway.

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17596
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com