[issue17637] Mention What's New in devguide's patch guidelines
Ezio Melotti added the comment: Patch updated. -- assignee: - ezio.melotti stage: patch review - commit review type: - enhancement Added file: http://bugs.python.org/file29778/issue17637-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Brett Cannon added the comment: LGTM -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Roundup Robot added the comment: New changeset 849b2fd4b06a by Ezio Melotti in branch 'default': #17637: mention What's New updating guidelines in the devguide. http://hg.python.org/devguide/rev/849b2fd4b06a -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Changes by Ezio Melotti ezio.melo...@gmail.com: -- resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Ezio Melotti added the comment: The What's new is already mentioned briefly in http://docs.python.org/devguide/committing.html#news-entries. Would it be enough to rephrase that part and clarify that committers are expected to update it? Another option is to add a new item to make patchcheck (and to http://docs.python.org/devguide/committing.html#patch-checklist), but I'm not sure it's worth doing it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Brett Cannon added the comment: Yep, I think expanding that would be fine. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Ezio Melotti added the comment: Patch attached. -- keywords: +patch stage: needs patch - patch review Added file: http://bugs.python.org/file29764/issue17637.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Brett Cannon added the comment: significative - significant I would also toss in something like or not backwards-compatible so people know they should mention anything that will require code change to stay backwards-compatible. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Antoine Pitrou added the comment: This is more the duty of the committer IMO. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Brett Cannon added the comment: Yes, but that doesn't mean it shouldn't be written down in the devguide (with appropriate note) that committers need to be thinking about this. Start good habits early. =) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Antoine Pitrou added the comment: Then it should probably go in http://docs.python.org/devguide/committing.html -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
Changes by Tshepang Lekhonkhobe tshep...@gmail.com: -- nosy: +tshepang ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17637] Mention What's New in devguide's patch guidelines
New submission from Brett Cannon: http://docs.python.org/devguide/patch.html should mention that What's New should also be considered for updating if a change is either significant or requires potential modification of existing code. -- components: Devguide messages: 186060 nosy: brett.cannon, ezio.melotti priority: normal severity: normal stage: needs patch status: open title: Mention What's New in devguide's patch guidelines ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17637 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
