[issue17642] IDLE add font resizing hot keys and wheel

[Tal Einat]

Change by Tal Einat :


--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys and wheel

[Zackery Spytz]

Change by Zackery Spytz :


--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys and wheel

[Terry J. Reedy]

Terry J. Reedy  added the comment:

#33397 add a FontSizer class to textview.py and uses it there and for the doc 
viewer in help.py.  It should be used for this issue also.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys and wheel

[Zackery Spytz]

Change by Zackery Spytz :


--
pull_requests: +16613
pull_request: https://github.com/python/cpython/pull/17107

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys and wheel

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I want this too, and part of it should be simple.  Given that I have had a 
never empty backlog of PRs to review for 2 1/2 years, it got forgotten.  There 
was also a tk problem that seemed to block implementation.

Specification for hotkey: Cntl/Cmd - -+= decrease/increase font size within 
limits in the current window only.  (The current limits for turtledemo are 6 
and 100.  Change this?  The keys are fixed and cannot be customized. Keys have 
no affect on IdleConf.  Setting font size in dialog continues to set font size 
for all Windows, whether individually set or not.  Should work same for editor 
and text (read-only) windows.

As near as I can tell, these key combinations currently do nothing.  I presume 
they are not bound in the built-in keysets.  Custom keysets are always subject 
to interference when we add new key bindings.  (I don't know that the custom 
key dialog checks against such fixed builtins. Another issue.  Checking custom 
keysets on import is likely a third issue.)

Implementation for hotkey: The desired behavior is the behavior of turtledemo, 
so the same implementation should work.  It is annoying that we need to add it 
separately for editor and text windows.  But refactoring to create a common 
base class would be a lot harder. 

Mousewheel: Currently, in turtledemo, control-wheel changes size on all 
systems.  

Raymond: Should it be cmd-wheel on Mac?

In msg226328 I reported a tk issue blocking both this and line numbers.  We now 
deliver 3.7.4 and 3.8.0 with tk 8.6.9.  We have line numbers because I no 
longer saw the glitchy behavior I remember.  Nor did I see any issue with font 
resizing with turtledemo.

I may include the module browser, etc, with this issue.  Dialogs would be 
another issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys and wheel

[Raymond Hettinger]

Raymond Hettinger  added the comment:

> Key or wheel patches will probably be 3.6 only.

I still have hopes that this will happen.

Am I correct in thinking that it wouldn't be difficult to map CMD-plus and 
CMD-minus (or for Windows Cntl-plus and Cntl-minus) to a function that 
increases or decreases the font-size without having to manually go to 
Preferences/FontsAndTabs?

--
versions: +Python 3.8, Python 3.9 -Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys and wheel

[Terry J. Reedy]

Terry J. Reedy added the comment:

I intend to backport the simple list expansion to 3.5.  Key or wheel patches 
will probably be 3.6 only.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys and wheel

[Roundup Robot]

Roundup Robot added the comment:

New changeset f478f9b88319 by Terry Jan Reedy in branch '2.7':
Issue #17642: add larger font sizes for classroom projection.
https://hg.python.org/cpython/rev/f478f9b88319

New changeset c9d59e6cc1e4 by Terry Jan Reedy in branch 'default':
Issue #17642: add larger font sizes for classroom projection.
https://hg.python.org/cpython/rev/c9d59e6cc1e4

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys and wheel

[Terry J. Reedy]

Terry J. Reedy added the comment:

https://stackoverflow.com/questions/39155656/i-need-bigger-font-in-python-idle/39156068#39156068
 is about getting a larger font size than 22 for classroom projection.  I think 
configdialog.py should be extended something as follows (about line 1000).

self.optMenuFontSize.SetMenu(('7', '8', '9', '10', '11', '12', '13',
  '14', '16', '18', '20', '22',
  '25', '30', '35', '40'), fontSize )
 
I think any new key or wheel should change by 1 over a large range rather than 
being constrained to the values on the list.  I will try to look at the patches 
before 3.6.  Tests should also be added.

--
assignee: roger.serwy -> terry.reedy
stage: needs patch -> patch review
title: IDLE add font resizing hot keys -> IDLE add font resizing hot keys and 
wheel
versions: +Python 3.6 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Mark Roseman]

Changes by Mark Roseman m...@markroseman.com:


--
nosy: +markroseman

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Terry J. Reedy]

Terry J. Reedy added the comment:

#21933 added font resizing hotkeys to turtle demo: Control/Command minus, 
underscore, equal, minus. The OS difference was handled by defining the prefix 
for the system.
shortcut = 'Command' if darwin else 'Control'
widget.bind_all('%s-minus' % shortcut, self._decreaseFont)

The patch also added including control-mousewheel. The discussion there 
revealed that Control-mousewheel up/down generates a Control-MouseWheel event 
with event.delta of +120/-120 on Windows, -1/+1 on Darwin, and 
Control-Button-4/Control-Button-5 events on X11. 

Control-mousewheel has a tk glitch in that it also generates ordinary 
mousewheel (scrolling) events. For turtledemo's read-only window of relatively 
short files, we decided not to worry.  Moving the cursor in edit windows would 
be a worry.

But Saimadhave and I discovered with line-numbering that this is also a problem 
with font resizing even without scrolling.  Text widgets send scroll up and 
down and back to start position commands to the scroll bar on font-resizing. 
See #17535, my tkfontsize.py test file, and the discussion thereof.

Also, the fontsize needs a minimum since tk (at least on Mac) treats negative 
sizes as positive sizes, so that decreasing past 0 increases.

This issue is *not* easy.

From the discussion (I have not read the patches yet), I am not sure whether 
the hotkey is intended to affect just the one window, like Context (and 
probably line numbering) or all,  I think it should just be the one window.

--
keywords:  -easy
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Raymond Hettinger]

Changes by Raymond Hettinger raymond.hettin...@gmail.com:


--
assignee:  - roger.serwy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Alejandro Rodas]

Alejandro Rodas added the comment:

I have merged the two patches: Now it queries the font size as I did in the 
original patch, and it also stores the position of the cursor based on Abhishek 
Kumar's modification of ZoomFont.py.

--
Added file: http://bugs.python.org/file30251/ZoomInOut.patch2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Roger Serwy]

Roger Serwy added the comment:

@Abhishek: I'd rather not require extensions to have a new method for resetting 
font sizes. Instead, a virtual event can be bound to a callback by the 
extension if it needs to know about a font change.

@Alejandro: It looks like there's a bug in ZoomFont.py where the cursor can go 
off screen which has propagated into these patches. That's my fault.

I'll take a look at these points later this week.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Abhishek Kumar]

Abhishek Kumar added the comment:

Thanks Roger, for the feedback especially the licence part. I have least idea 
about licences but will take care in future.

One question: Is it right to change IdleConf on Ctrl+ and Ctrl- ? I mean to 
change font for all open windows?
It happens with most text editors but not with browsers.

To remove those 2 hacks for CodeContext and LineNumbers, what we can do is 
write a ResetFont() for each extenstion and can call it from the ResetFont() of 
editor window like this: 
for extension in self.extensions:
extension.ResetFont()
so that we don't have to write seperate font-size hacks for each extension 
while resetting the font.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Alejandro Rodas]

Changes by Alejandro Rodas alexrd...@gmail.com:


Added file: http://bugs.python.org/file30074/ZoomInOut.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Roger Serwy]

Roger Serwy added the comment:

Abhishek, Alejandro, welcome to IDLE development! If you can, please sign a 
contributor agreement.

We have two patches to create this enhancement, both are good. I suggest that 
we figure out how to merge the solutions.

The zoom-out binding should also include Ctrl-Equal, so that holding shift is 
no longer necessary. There's also a corner case where the zooming in on the 
editor may cause the cursor to go outside of viewing window.

Using idleConf to query the font information is not strictly necessary since 
the font configuration in the text widget contains the font size already.

In the future, please be careful with licensing. The top part of the 
ZoomFont.py extension places it under the NCSA license. Fortunately UIUC has 
allowed me to relicense parts IdleX for the Python Software Foundation.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Alejandro Rodas]

Alejandro Rodas added the comment:

I have made a patch to zoom in and out with Control-plus and Control-minus 
events, respectively. I'll upload it soon since the test suite is giving me an 
error in test_multiprocessing, even before writing the patch.

I have taken a look at ZoomFont.py of IdleX and it also has the option to reset 
the font size to its original value, but I don't know if this feature was 
wanted to be added too. However, ZoomFont controls the size of the LineNumber 
extension, while this patch only changes the font of the editview's text widget.

--
nosy: +alex.rodas

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Abhishek Kumar]

Abhishek Kumar added the comment:

I have submitted a patch that is working fine on Windows and on Ubuntu. I have 
used ZoomFont.py of IdleX.

On pressing Ctrl+ or Ctrl- it changes the user configuration and updates the 
font of all open windows as there is a common user configuration for all 
windows. I have removed polling from CodeContext instead I set font of 
CodeContext on every font change.

As this is my first patch. Please review it and give your valuable feedback.

--
keywords: +patch
nosy: +Abhishek.Kumar
Added file: http://bugs.python.org/file30051/issue17642_patch2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Alejandro Rodas]

Alejandro Rodas added the comment:

I have uploaded my patch as well, it doesn't make use of tkfont (just vanilla 
Tkinter methods) and it works both in Python 2.7 and 3.4 without the need of 
any import.

I think the main difference with Abhishek Kumar's version is that mine does not 
use idleConf to retrieve and set the font size. However, the original 
ZoomFont.py of IdleX does not use it. Is it really necessary?

--
Added file: http://bugs.python.org/file30053/ZoomInOut.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Alejandro Rodas]

Changes by Alejandro Rodas alexrd...@gmail.com:


Removed file: http://bugs.python.org/file30053/ZoomInOut.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Alejandro Rodas]

Alejandro Rodas added the comment:

Sorry, I submitted a patch which only works on Windows. This one has been 
tested on Ubuntu too.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Todd Rovito]

Changes by Todd Rovito rovit...@gmail.com:


--
nosy: +Todd.Rovito

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Terry J. Reedy]

Terry J. Reedy added the comment:

On Windows, cntl-+. cntl--

Could we use the tk event system by defining font change events and event 
handlers?

--
nosy: +terry.reedy
versions:  -Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Raymond Hettinger]

New submission from Raymond Hettinger:

Add the standard hot keys for resizing fonts (i.e. on a Mac, CMD-plus and 
CMD-minus).

--
components: IDLE
keywords: easy
messages: 186118
nosy: rhettinger
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE add font resizing hot keys
type: enhancement
versions: Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Edmond Burnett]

Changes by Edmond Burnett eburn...@gmail.com:


--
nosy: +edmond.burnett

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Giampaolo Rodola']

Changes by Giampaolo Rodola' g.rod...@gmail.com:


--
nosy: +giampaolo.rodola

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17642] IDLE add font resizing hot keys

[Roger Serwy]

Roger Serwy added the comment:

IdleX provides this with the ZoomFont.py extension. (See 
http://idlex.sourceforge.net/extensions.html#Misc) It is useful for showing 
code on a projector so that students can easily read the screen.

The implementation in ZoomFont.py does not change the font size found in IDLE's 
configuration. Instead it queries the font size in the text widget and scales 
accordingly with a relative offset. 

IDLE needs a better way to broadcast font configuration changes. Right now, the 
Code Context extension uses polling every second to check for font changes. I 
bring this point up because properly incorporating font zooming may require 
refactoring some code. Incorporating Line Numbers, from #17535 would likely 
need to rely on this font size broadcasting as well.

--
nosy: +roger.serwy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17642
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com