[issue17735] inspect.findsource raises IndexError

2020-12-04 Thread Tal Einat 


Tal Einat  added the comment:

Thanks for reporting this, Kyle!

Thanks for the PR, Irit!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2020-12-04 Thread Tal Einat 


Tal Einat  added the comment:


New changeset d1f07419c7560ed3ba52ba4f667f4eec9b5fe95d by Miss Islington (bot) 
in branch '3.9':
bpo-17735: inspect.findsource now raises OSError when co_lineno is out of range 
(GH-23633)
https://github.com/python/cpython/commit/d1f07419c7560ed3ba52ba4f667f4eec9b5fe95d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2020-12-04 Thread miss-islington 


miss-islington  added the comment:


New changeset a4e7d5f750e06e31a80a83c2af02b1a40cecd0ff by Miss Islington (bot) 
in branch '3.8':
bpo-17735: inspect.findsource now raises OSError when co_lineno is out of range 
(GH-23633)
https://github.com/python/cpython/commit/a4e7d5f750e06e31a80a83c2af02b1a40cecd0ff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2020-12-04 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +22515
pull_request: https://github.com/python/cpython/pull/23647

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2020-12-04 Thread miss-islington 


Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 5.0 -> 6.0
pull_requests: +22514
pull_request: https://github.com/python/cpython/pull/23646

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2020-12-04 Thread Tal Einat 


Tal Einat  added the comment:


New changeset 2e0760bb2edb595050aff82f236cd32b44d3dfb3 by Irit Katriel in 
branch 'master':
bpo-17735: inspect.findsource now raises OSError when co_lineno is out of range 
(GH-23633)
https://github.com/python/cpython/commit/2e0760bb2edb595050aff82f236cd32b44d3dfb3


--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2020-12-03 Thread Irit Katriel 


Change by Irit Katriel :


--
keywords: +patch
pull_requests: +22502
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23633

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2020-12-03 Thread Irit Katriel 


Irit Katriel  added the comment:

Sorry, you're right - now the issue is when you remove functions from the 
module:

>>> reload(x)

>>> help(x)
Traceback (most recent call last):
  File "", line 1, in 
  File "C:\Users\User\src\cpython\\lib\_sitebuiltins.py", line 103, in __call__
return pydoc.help(*args, **kwds)
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 2000, in __call__
self.help(request)
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 2059, in help
else: doc(request, 'Help on %s:', output=self._output)
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 1779, in doc
pager(render_doc(thing, title, forceload))
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 1772, in render_doc
return title % desc + '\n\n' + renderer.document(object, name)
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 472, in document
if inspect.ismodule(object): return self.docmodule(*args)
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 1273, in docmodule
contents.append(self.document(value, key, name))
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 474, in document
if inspect.isroutine(object): return self.docroutine(*args)
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 1510, in docroutine
doc = getdoc(object) or ''
  File "C:\Users\User\src\cpython\lib\pydoc.py", line 187, in getdoc
result = _getdoc(object) or inspect.getcomments(object)
  File "C:\Users\User\src\cpython\lib\inspect.py", line 882, in getcomments
lines, lnum = findsource(object)
  File "C:\Users\User\src\cpython\lib\inspect.py", line 871, in findsource
if pat.match(lines[lnum]): break
IndexError: list index out of range

--
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 2.7, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2020-12-03 Thread Irit Katriel 


Irit Katriel  added the comment:

I'm unable to reproduce it now. Has it been fixed?

>>> import x
>>> help(x)
Help on module x:

NAME
x

FUNCTIONS
func()

FILE
c:\users\user\src\cpython\x.py


>>> from importlib import reload
>>> reload(x)

>>> help(x)
Help on module x:

NAME
x

FUNCTIONS
func()

newfunc()

FILE
c:\users\user\src\cpython\x.py

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2014-05-05 Thread Jason R. Coombs 

Jason R. Coombs added the comment:

This issue appears implicated in https://bitbucket.org/pypa/setuptools/issue/201

--
nosy: +jason.coombs

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17735
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17735] inspect.findsource raises IndexError

2013-04-19 Thread Éric Araujo 

Changes by Éric Araujo mer...@netwok.org:


--
title: inspect.findsource throws IndexError - inspect.findsource raises 
IndexError

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17735
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com