[issue17905] Add check for locale.h

[Roman Evstifeev]

Changes by Roman Evstifeev :


--
nosy: +Roman.Evstifeev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Stefan Krah]

Stefan Krah added the comment:

I think all locale includes are unguarded now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Roundup Robot]

Roundup Robot added the comment:

New changeset cc501d439239 by Stefan Krah in branch 'default':
Issue #17905: Do not guard locale include with HAVE_LANGINFO_H.
https://hg.python.org/cpython/rev/cc501d439239

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Stefan Krah]

Stefan Krah added the comment:

Okay, closing as a duplicate (the second patch here that checks for
locale.h seems too broad to me since it's a standard header).

--
nosy: +skrah
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> Interpreter fails in initialize on systems where 
HAVE_LANGINFO_H is undefined
versions: +Python 3.6 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Xavier de Gaye]

Xavier de Gaye added the comment:

Android API level 21 has a full fledged locale.h now.
There is still no langinfo.h, this issue is a duplicate of issue #22747.

--
nosy: +xdegaye

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Antoine Pitrou]

Antoine Pitrou added the comment:

There are more places where including locale.h is guarded by HAVE_LANGINFO_H.

Also, there are places where including locale.h isn't guarded by anything (such 
as Python/formatter_unicode.c), so I don't think we need the new configure 
check.

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17905
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Antonio Cavallo]

Antonio Cavallo added the comment:

I see, in that case wouldn't make more sense completely remove the check for 
the langinfo.h either?

I think is better to close the issue to keep the noise low.
Thanks

--
resolution:  - works for me
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17905
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Antoine Pitrou]

Antoine Pitrou added the comment:

You might have misunderstood me. Since locale.h appears to exist on all systems 
(including Android) there's no need to add a check for it in configure. On the 
other hand, it is correct to fix the existing guards like your patch proposes 
to do, except that there appears to be more places to fix.

I'm reopening the issue.

--
resolution: works for me - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17905
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Antonio Cavallo]

Antonio Cavallo added the comment:

ok I see it, thanks.

I've attached a new patch fixing the files with the locale's guards.

Modules/readline.c might have the SAVE_LOCALE renamed into HAVE_SETLOCALE but 
the patch doesn't address that bit.

Android has definitively locale.h but it is a dummy implementation at the 
moment. I'm trying with http://www.crystax.net/en/android/ndk instead but still 
no luck.

--
Added file: http://bugs.python.org/file30228/locale_h_configure.ac.patch2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17905
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


--
versions:  -Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17905
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17905] Add check for locale.h

[Antonio Cavallo]

New submission from Antonio Cavallo:

This patch adds autoconf.ac check for the locale.h file in addition to 
langinfo.h. The patch contains also a fix to Python/fileutils.c file.

The android ndk provides locale.h but no langinfo.h: this fixes the issue.

BTW bionic doesn't have any runtime support for locale at the moment in the 
standard build at least.

--
components: Build, Cross-Build
files: locale_h_configure.ac.patch
keywords: patch
messages: 188362
nosy: benjamin.peterson, cavallo71, doko, haypo
priority: normal
severity: normal
status: open
title: Add check for locale.h
type: enhancement
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file30123/locale_h_configure.ac.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17905
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com