[issue17912] thread states should use a doubly-linked list
Antoine Pitrou added the comment: Your patch looks fine to me, thank you. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17912] thread states should use a doubly-linked list
Roundup Robot added the comment: New changeset 375d4fed4cf2 by Charles-Francois Natali in branch 'default': Issue #17912: Use a doubly linked-list for thread states. http://hg.python.org/cpython/rev/375d4fed4cf2 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17912] thread states should use a doubly-linked list
Changes by Charles-François Natali cf.nat...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17912] thread states should use a doubly-linked list
Charles-François Natali added the comment: There are a couple other places, IIRC. That said, I'm not sure what the point is, since a linked list is quite a simple structure anyway? Well, it was just to avoid code duplication, and gain a nice iteration macro ;-) Anyway, I'll submit a patch later today. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17912] thread states should use a doubly-linked list
Changes by Charles-François Natali cf.nat...@gmail.com: -- keywords: +needs review, patch stage: needs patch - patch review Added file: http://bugs.python.org/file30168/pystate.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17912] thread states should use a doubly-linked list
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17912] thread states should use a doubly-linked list
Charles-François Natali added the comment: Are there other places in the code base using linked-list? If yes, I think it could be interesting to add a generic linked-list implementation, like the one used in the Linux kernel: http://kernelnewbies.org/FAQ/LinkedLists http://isis.poly.edu/kulesh/stuff/src/klist/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17912] thread states should use a doubly-linked list
Antoine Pitrou added the comment: Are there other places in the code base using linked-list? If yes, I think it could be interesting to add a generic linked-list implementation, like the one used in the Linux kernel: http://kernelnewbies.org/FAQ/LinkedLists http://isis.poly.edu/kulesh/stuff/src/klist/ There are a couple other places, IIRC. That said, I'm not sure what the point is, since a linked list is quite a simple structure anyway? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17912] thread states should use a doubly-linked list
New submission from Antoine Pitrou: Thread states are stored in a singly linked list, which makes some operations more cumbersome than they should be. Since memory consumption is far from critical here, it would be easier to handle them with a doubly linked list. -- components: Interpreter Core messages: 188471 nosy: pitrou priority: low severity: normal stage: needs patch status: open title: thread states should use a doubly-linked list type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17912 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
