[issue18040] SIGINT catching regression on windows in 2.7
Changes by Gabi Davar grizzly@gmail.com: -- nosy: +Gabi.Davar ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18040] SIGINT catching regression on windows in 2.7
Tim Golden added the comment: Personally, I'm +0 at best on this change. It would achieve consistency with Linux but I'm not sure what you'd do with such functionality. Adding Richard Oudkerk who did the rework of the interrupt signal for 3.3. Richard, any opinion on this? -- nosy: +sbt priority: normal - low stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18040] SIGINT catching regression on windows in 2.7
Richard Oudkerk added the comment: I am not to familiar with the signal handling machinery. (I only did some refactoring to expose the event handle already used by time.sleep().) The change looks reasonable, but I am also not sure how necessary it is. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18040] SIGINT catching regression on windows in 2.7
David Gilman added the comment: So the original motivation here was to piggyback on SIGINT in order to do something like this on Windows: http://stackoverflow.com/questions/132058/showing-the-stack-trace-from-a-running-python-application I've given Tim's patch a shot and I see that I've been barking up the wrong tree. I agree that this one-liner is a kinda invasive change and probably isn't worth putting in a point release. Thanks for the help. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18040] SIGINT catching regression on windows in 2.7
Tim Golden added the comment: Thanks for the feedback, David. Closing as won't fix. -- resolution: - wont fix stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18040] SIGINT catching regression on windows in 2.7
Tim Golden added the comment: Correction: I see the desired behaviour in 3.3/3.4 which is where the overhaul to Ctrl-C handling on Windows was applied. I still can't see it in 2.6 or in 3.1/3.2 on Windows. The problem lies in the fact that PyOS_InterruptOccurred and PyErr_CheckSignals from signalmodule.c both check and reset signalled events. The former is used (solely within myreadline.c) to determine whether a SIGINT has fired; the latter is called in many different places to initiate Python's signal-handling but doesn't return any information about which signal fired. The check in line 70 of Parser/myreadline.c determines that a SIGINT signal has fired, but clears that signal at the same time. Any later call to PyErr_CheckSignals will not see that the SIGINT had fired. The 3.3+ situation is different, as a Windows event is the indication that SIGINT was raised, and the check for this doesn't affect the internal Handlers table which is examined by PyErr_CheckSignals. The attached patch to signalmodule.c appears to produce SIGINT signal handling as desired. Tested only on Windows. It's not clear whether any unittest could be produced for this kind of functionality. -- keywords: +patch Added file: http://bugs.python.org/file30382/signalmodule.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___diff --git a/Modules/signalmodule.c b/Modules/signalmodule.c --- a/Modules/signalmodule.c +++ b/Modules/signalmodule.c @@ -974,7 +974,6 @@ if (PyThread_get_thread_ident() != main_thread) return 0; #endif -Handlers[SIGINT].tripped = 0; return 1; } return 0; ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18040] SIGINT catching regression on windows in 2.7
Tim Golden added the comment: My initial reaction is that, whether the 2.7 behaviour is faulty or not, I can't reproduce the correct behaviour on any version of Windows going back to 2.4. Take the attached Python file issue18040.py and run c:\pythonxx\python.exe -i issue18040.py for any version of Python from 2.4 to 3.4. At the interpreter prompt, pressing Ctrl-C produces Keyboard Interrupt consistently (except for the few times it exits the interpreter which is the problem fixed in issue1677). Note that this applies to pressing Ctrl-C *at the interpreter prompt* (while the running code is the function my_fgets in parser/myreadline.c). Pressing Ctrl-C in other circumstances, eg in the middle of a long-running os.walk or a time.sleep, invokes the signal handler as expected. I don't know if the handler *should* be invoked at the interpreter prompt. I recognise that it does so under Linux, but are there any circumstances where that would actually be useful? -- assignee: - tim.golden Added file: http://bugs.python.org/file30370/issue18040.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18040] SIGINT catching regression on windows in 2.7
Changes by Martin v. Löwis mar...@v.loewis.de: -- nosy: +loewis, tim.golden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18040] SIGINT catching regression on windows in 2.7
New submission from David Gilman: I opened this StackOverflow bug with an example simplified testcase. As you can see in the first comment a user added that this code worked under Python 2.6 on Windows and no longer works on 2.7. http://stackoverflow.com/questions/16686510/how-do-i-capture-sigint-in-python-on-windows?noredirect=1#comment24013681_16686510 Here's a patch that went into the 2.7 release that maybe is related? http://bugs.python.org/issue1677 -- messages: 189843 nosy: David.Gilman priority: normal severity: normal status: open title: SIGINT catching regression on windows in 2.7 versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18040 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
