[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Terry J. Reedy added the comment: This is working, so closing. I opened #18604 for consolidating gui checks in test.support. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Roundup Robot added the comment: New changeset c57b2a344097 by Terry Jan Reedy in branch '3.3': Issue #18441: Remove check from test_text.py in 3.3,4 (already done in 2.7). http://hg.python.org/cpython/rev/c57b2a344097 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Roundup Robot added the comment:
New changeset dd9941f5fcda by Terry Jan Reedy in branch '2.7':
Issue #18441: Make test.support.requires('gui') skip when it should.
http://hg.python.org/cpython/rev/dd9941f5fcda
New changeset d9a53ab464ea by Terry Jan Reedy in branch '2.7':
Issue #18441: Correct previous patch, which hg committed before I wanted it to.
http://hg.python.org/cpython/rev/d9a53ab464ea
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18441
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Roundup Robot added the comment: New changeset 9a4c62c1a4c0 by Terry Jan Reedy in branch '2.7': Issue #18441: add Mac (darwin) gui check. This is not needed today, but has been http://hg.python.org/cpython/rev/9a4c62c1a4c0 New changeset ba5c264d67ea by Terry Jan Reedy in branch '2.7': Issue #18441: Comment out code that will not compile because the standard http://hg.python.org/cpython/rev/ba5c264d67ea New changeset 6420dcd377f9 by Terry Jan Reedy in branch '2.7': Issue #18441: whitespace http://hg.python.org/cpython/rev/6420dcd377f9 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Terry J. Reedy added the comment: I tried to run the currently unnecessary Mac 'darwin' check in 2.7 with if sys.platform == 'darwin': from lib-tk.test.runtktests import check_tk_availability # tkinter.test.suppport in 3.x try: check_tk_availability() except unittest.SkipTest: raise tk.TclError This fails because 'lib-tk' is not a legal module name. There are workarounds in test/test_tk.py and test_ttk_guionly, but I decided not to bother with them now because I would rather work on moving the function to test.support (and perhaps the package could be given a legal name). If, before that is done, someone adds a Mac buildbot that will not run gui tests but requests that they be run anyway, the above could be added with the different changes needed for 2.7 and 3.x. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Roundup Robot added the comment:
New changeset c3936a52f215 by Terry Jan Reedy in branch '3.3':
Issue #18441: Make test.support.requires('gui') skip when it should.
http://hg.python.org/cpython/rev/c3936a52f215
New changeset 858a72d91162 by Terry Jan Reedy in branch '2.7':
Issue #18441: Move commented out code to issue message.
http://hg.python.org/cpython/rev/858a72d91162
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18441
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Roundup Robot added the comment:
New changeset 23b0164b9c82 by Terry Jan Reedy in branch '2.7':
Issue #18441: Make test.support.requires('gui') skip when it should.
http://hg.python.org/cpython/rev/23b0164b9c82
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18441
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Terry J. Reedy added the comment: I took a look. Not fun ;-). Pending a more permanent fix, I am applying a revised patch, first to 2.7 to make sure it works. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Roundup Robot added the comment: New changeset 9f922270a929 by Terry Jan Reedy in branch '2.7': Issue #18441: fix buildbot name-error for TclError. http://hg.python.org/cpython/rev/9f922270a929 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Roundup Robot added the comment: New changeset e8b8279ca118 by Terry Jan Reedy in branch '2.7': Backed out changeset: 23b0164b9c82 #18441 not working http://hg.python.org/cpython/rev/e8b8279ca118 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Terry J. Reedy added the comment: (The fix was incomplete because 'delete' in the except clause should be 'remove'.) I finally realized that I could test the except clause by raising TclError explicitly just before it. I reverted both changes because they do not seem to work, even with the additional fix (not committed). With or without patches, python_d -m test -v test_idle # runs 30 tests, as expected python_d -m test -v -ugui test_idle # run 40 tests, as expected After raising TclError, the latter still runs 40 tests, which I did not expect. It seems that 'gui' is not being removed from use_resources. Since debug print()s in test_idle do not show up on the console, I cannot easily see what is going on. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Terry J. Reedy added the comment: More noise. Much of what I said above was incorrect due to version mixup. The one extra fix I did not commit might have been enough, but I will wait until I have tested it. -- stage: commit review - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Changes by Todd Rovito rovit...@gmail.com: -- nosy: +Todd.Rovito ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Changes by Todd Rovito rovit...@gmail.com: -- nosy: +JayKrish ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Changes by Todd Rovito rovit...@gmail.com: -- nosy: +philwebster ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
New submission from Terry J. Reedy:
This is a continuation of #18365, where it was discovered after the first set
of pushes that
test.support.requires('gui')
is currently insufficient (on non-Windows systems) for skipping gui tests on
buildbots when they should be skipped, because the attempt to create a Tk root
widget will raise TclError when there is no display available.
This bug appears to arise from the confluence of two bugs:
1. It appears that on some buildbots, support.use_resources contains 'gui' when
it should not. The could be either from -ugui or -uall without '.-gui' or ???.
2. test.support.requires starts with
if resource == 'gui' and not _is_gui_available():
On windows, _is_gui_available() uses ctypes to determine that there really is a
graphics screen (or something like that). On other systems, it just returns
True, even when it should return False.
The problem was fixed for #18365 by wrapping the tkinter.Tk call with
try:...except: TclErrror: raise SkipTest. Rather than put something like that
workaround in every idle_test/test_xxx file, I would like to do the test once
in test/test_idle and if it does not work, remove 'gui' from use_resources so
requires('gui') will work properly. See patch.
test/test_ttkguionly does not use requires() (and therefore does not do the
special Windows check). It first tries to import _tkinter, as does test_idle.
It then calls tkinter.test.support.check_tk_availability. That either does a
'darwin'-ctypes check similar to the one for Windows in _is_gui_available or it
tries to create a tk widget and looks for a TclError. test_ttkguionly then
repeats the widget creation test.
This checking is ok for one file, but not for gui tests sprinkled throughout
idle's test_xxx files. Perhaps requires('gui') not being dependable is why
there is a separate test_ttkguionly file *and* a custom discovery function,
tkinter.test.runtests.get_tests, to get only gui tests.
test/test_tk does the same except that is does not repeat the widget creation
test. Both add 'gui' to use_resources when the file is run as main, though in a
more convoluted manner than in test_idle. I am sure that removing 'gui' in
test_idle cannot hurt since test_tk/ttk_gui-only skip anyway on a similar
TclError. There is no test_turtle.py.
The check should really be done in regrtest, but I am not familiar with its
code or the policy on patching it. Then tkinter tests could also dispense with
their extra checks and more easily be converted to use unittest discovery. But
that is not my concern here.
--
assignee: terry.reedy
files: delete_gui.diff
keywords: patch
messages: 193015
nosy: r.david.murray, terry.reedy
priority: high
severity: normal
stage: commit review
status: open
title: Idle: Make test.support.requires('gui') skip when it should.
type: behavior
versions: Python 2.7, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file30909/delete_gui.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18441
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Ned Deily added the comment: See Issue8716 for the history of check_tk_availability(). At the time, the Tk tests were the only ones trying to create real Tk objects (and thus causing crashes on some buildbot configurations). With the addition of IDLE tests that call Tk, it probably makes sense to refactor check_tk_availability() into the common test test_support/support helper module so it can be used globally. -- nosy: +ned.deily ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
