[issue18590] Found text not always highlighted by Replace dialog on Windows

[Terry J. Reedy]

Terry J. Reedy added the comment:

Since the original bug for this issue has been fixed, I am closing it in favor 
of #29392

--
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed
superseder:  -> IDLE search and replace should use 'hit' tag instead of 'hilite'

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18590] Found text not always highlighted by Replace dialog on Windows

[Terry J. Reedy]

Terry J. Reedy added the comment:

#24972 fixes the immediate issue but the Find and Replace code are needlessly 
different in doing the same thing and redundant in double tagging found text, 
and there are some other glitches.  I think a better fix will be to only use 
the found tag, but this needs discussion, perhaps on idle-dev. #22179 also has 
some discussion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18590] Found text not always highlighted by Replace dialog on Windows

[Mark Roseman]

Mark Roseman added the comment:

See #24972 for fix

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18590] Found text not always highlighted by Replace dialog on Windows

[Mark Roseman]

Changes by Mark Roseman :


--
nosy: +markroseman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18590] Found text not always highlighted by Replace dialog on Windows

[Saimadhav Heblikar]

Saimadhav Heblikar added the comment:

I tested for the behaviour described in msg193895 before and after your patch. 
Everything remains same except as what you mentioned.

Currently, Replace dialog Find hits are tagged with both the 'hit' and the 
'sel' tag, which does not show on Windows as long as the dialog is the active 
window, but apparently does on other systems.  Raising the hit tag to the top 
(either patch) means that the visible highlight on other systems will change 
from 'selected' to 'found' (which are independently configurable in Idle 
preferences).

If this not desired, the patch could be altered to use tag 'hit' on Windows 
and 'sel' elsewhere; change 'hit' (on Windows) to 'sel' when the dialog is 
closed; and configure 'hit' to look like 'sel' (so there is no visible change 
when closing, as on other systems).

It would be better to ensure that there is no visible change when closing.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18590
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18590] Found text not always highlighted by Replace dialog on Windows

[Terry J. Reedy]

Terry J. Reedy added the comment:

Additional notes: Sarah's Replace patch consists of the tag raise.  I just 
verified the reason why it works and moved it to the dialog base to include 
output windows and soon, Search dialogs.  Sarah, if you do not provide a 
'family' name, I will list you in Misc/ACKS, in alphabetical position, as just 
'Sarah'.  Or are you already in that file?

Currently, Replace dialog Find hits are tagged with both the 'hit' and the 
'sel' tag, which does not show on Windows as long as the dialog is the active 
window, but apparently does on other systems.  Raising the hit tag to the top 
(either patch) means that the visible highlight on other systems will change 
from 'selected' to 'found' (which are independently configurable in Idle 
preferences).

If this not desired, the patch could be altered to use tag 'hit' on Windows and 
'sel' elsewhere; change 'hit' (on Windows) to 'sel' when the dialog is closed; 
and configure 'hit' to look like 'sel' (so there is no visible change when 
closing, as on other systems).

On Windows, only one slice can be selected and I presume this is true on other 
systems.  If so, a non-'sel' tag is needed on all systems to tag multiple hits. 
 I would like to auto-highlight all hits in grep output windows and add an 
explicit 'find in current file' option (though it is possible now by adding the 
file name to the search path).

Raymond, I added you as nosy since this is an appearance change issue that you 
might possibly have an opinion on, and I would prefer getting it before a 
change is released in January  If I am wrong, un-nosy yourself.

--
nosy: +rhettinger
title: Found text not always highlighted by Replace dialog - Found text not 
always highlighted by Replace dialog on Windows

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18590
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com