[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[David Goncalves]

Change by David Goncalves :


--
nosy: +dpg
nosy_count: 8.0 -> 9.0
pull_requests: +30340
pull_request: https://github.com/python/cpython/pull/32279

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Felipe Rodrigues]

Change by Felipe Rodrigues :


--
pull_requests: +9550

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Jessica McKellar]

Changes by Jessica McKellar jesst...@mit.edu:


--
keywords: +needs review
stage: needs patch - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Ben Galin]

Ben Galin added the comment:

Added a patch with these two 8859-8 aliases and a corresponding test in 
test_codecs.py (couldn't find test_encodings.py mentioned in an earlier 
message).  The test also found a missing 'tactis' codec (issue 1251921), so 
I've commented it out in the aliases.py file.  Please take a look.

--
nosy: +bensws
Added file: http://bugs.python.org/file35736/8859-8_aliases_and_test.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Kamilla]

Kamilla added the comment:

Adding aliases to the set of iso-8859-8.

--
keywords: +patch
Added file: http://bugs.python.org/file34449/adding_aliases.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[R. David Murray]

R. David Murray added the comment:

From python's point of view they are both aliases of iso-8859_8, as discussed 
in this issue.  Python does not have iso-8859_8-e and i codecs, which you 
changes to the alias table implies that it does (the target of the entry in 
the aliases table is the python codec name...and there is only iso8859_8.py, 
not iso8859_8_E.py or _I.py).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[R. David Murray]

R. David Murray added the comment:

The tests are in test_encodings.py.  It is interesting that the tests pass with 
your patch applied; that indicates that there is a missing test, since we 
should be testing that all of the values in the aliases table are the names of 
existing codecs, and apparently we aren't.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Kamilla]

Kamilla added the comment:

I'm not sure about how the aliases are represented. I found some examples:

http://web.mit.edu/Mozilla/src/mozilla/intl/uconv/src/charsetalias.properties

So I wrote the aliases like this:

'iso-8859-8-i'   : 'iso8859_8_I',
'iso-8859-8-e'   : 'iso8859_8_E',

But I'm not sure if I should write as shown in the example above or if it 
should looks like:

'iso-8859-8-i'   : 'iso8859_8',
'iso-8859-8-e'   : 'iso8859_8',

And how about the tests? I couldn't locate the tests for this module. It it the 
tests inside the enconded_modules folder?

--
nosy: +kamie

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[M. Volz]

Changes by M. Volz marie...@gmail.com:


--
nosy: +mvolz

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Dan Søndergaard]

Dan Søndergaard added the comment:

Is it satisfactory to just add the -i and -e variants to ALIASES in charset.py? 
Or don't they qualify as Aliases for other commonly-used names for character 
sets?

--
nosy: +das

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[R. David Murray]

R. David Murray added the comment:

This issue is actually about adding the aliases to the codecs module.  I'm not 
entirely sure at this point what the canonical character set name should be for 
email output (which is what the ALIASES table controls).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

On 02.08.2013 16:37, R. David Murray wrote:
 
 I got the impression from what I read that -e included additional control 
 sequences, but perhaps I misunderstood and that only meant that the data 
 stream was expected to *use* additional control sequences but the control 
 codes themselves are part of the base codec?
 
 I'm specifically thinking of this statement from the linked reference:
 
 Because HTML uses the Unicode bidirectionality algorithm, conforming 
 documents encoded using ISO 8859-8 must be labeled as ISO-8859-8-i. 
 Explicit directional control is also possible with HTML, but cannot be 
 expressed with ISO 8859-8, so ISO-8859-8-e should not be used.
 
 The cannot be expressed seems to imply there are differences in the codec.

No, not really. After some more research, I found that the -i and
-e suffixes are defined in RFC 1556:

http://tools.ietf.org/html/rfc1556

At the codec level, these encodings are all the same. The suffixes
define whether or not to interpret some of their control characters
with respect to bidi text when visualizing the text.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

Here's a usable reference:

http://www.w3.org/TR/html4/struct/dirlang.html#bidi88598

+1 on adding the alias.

Also see

http://lists.gnu.org/archive/html/lynx-dev/2012-02/msg00041.html

for how Lynx does this.

The URL also mentions iso-8859-8-e, which should probably also be aliased to 
iso-8859-8. Both names only apply to visual display characteristics of the 
text; the encoding is the same.

--
nosy: +lemburg

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[R. David Murray]

R. David Murray added the comment:

I got the impression from what I read that -e included additional control 
sequences, but perhaps I misunderstood and that only meant that the data stream 
was expected to *use* additional control sequences but the control codes 
themselves are part of the base codec?

I'm specifically thinking of this statement from the linked reference:

Because HTML uses the Unicode bidirectionality algorithm, conforming documents 
encoded using ISO 8859-8 must be labeled as ISO-8859-8-i. Explicit 
directional control is also possible with HTML, but cannot be expressed with 
ISO 8859-8, so ISO-8859-8-e should not be used.

The cannot be expressed seems to imply there are differences in the codec.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[R. David Murray]

New submission from R. David Murray:

Emails and web pages may specify a character set of iso-8859-8-i, which has 
exactly the same code points as iso-8859-8. The -i has to do with how 
bi-directional text is handled, but doesn't affect the encoding: 
http://lists.w3.org/Archives/Public/www-validator/2001Apr/0008.html

--
components: Unicode, email
keywords: easy
messages: 194134
nosy: barry, ezio.melotti, r.david.murray
priority: normal
severity: normal
stage: needs patch
status: open
title: Add alias for iso-8859-8-i which is the same as iso-8859-8
type: enhancement
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18624
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com