[issue18731] Increased test coverage for uu and telnet
Serhiy Storchaka added the comment: test_encode_defaults is failed now. Don't use hardcoded filename length. And I don't understand the purpose of changes in uu.py. -- versions: +Python 2.7, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18731 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18731] Increased test coverage for uu and telnet
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18731 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18731] Increased test coverage for uu and telnet
New submission from Alex Volkov: Okay, I'm submitting the patch just for uu / test_uu. I replaced all try/finally statemets with 'with' context, added try..finally statement for both test cases. uu.py, line 61 is exposed by test_encode_osstat_assert -- os.stat is duckpunched out of the system, then test case verifies that default permissions(666) is written into a file. I didn't have try...finally statement because I wasn't sure how the test case will behave when inner try..finally is triggered, so far the tests seem to pass.. -- Added file: http://bugs.python.org/file31489/uu_test_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18731 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18731] Increased test coverage for uu and telnet
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18731 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18731] Increased test coverage for uu and telnet
Changes by Antoine Pitrou pit...@free.fr: -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18731 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18731] Increased test coverage for uu and telnet
Changes by Alex Volkov avol...@gmail.com: -- components: Tests files: telnet_uu_tests.patch keywords: patch nosy: Alex.Volkov priority: normal severity: normal status: open title: Increased test coverage for uu and telnet type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file31284/telnet_uu_tests.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18731 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com