[issue18889] test_sax: multiple failures on Windows desktop
Tim Peters added the comment: Suggest caution here. test_sax fails the same way for me too (Windows Vista), under both the released 3.3.2 and a Python built from the current hg default branch. However, these files (test.xml and test.xml.out) have not changed since the Python 2.7 line - the \r\n line endings have _always_ been there, and test_sax works fine under (e.g.) Python 2.7.5 on Windows. So it's not that the files have changed, it must be that Python is behaving differently. Unfortunately, I don't know anything about what test_sax is trying to do. I do see that under 2.7, test_sax does xml_test_out = open(TEST_XMLFILE_OUT).read() but 3.3 does with open(TEST_XMLFILE_OUT, 'rb') as f: xml_test_out = f.read() That is, 2.7 opens the file for reading in text mode, but 3.3 opens it in binary mode. That makes a big difference for text files under Windows. It's also disturbing that the Windows buildbots don't fail. There is no change in environment that should affect the bytes seen when a file is read - and the buildbots should be seeing, byte for byte, the same files developers and users see. -- nosy: +tim.peters ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Tim Peters added the comment: Seeing as Python 3 _does_ open these files in binary mode, I fiddled my local .hgeol to mark the test files as BIN (then deleted the test data directory and did an hg revert on the directory). Then test_sax passes. I don't know whether that's the proper fix, but it works ;-) -- Added file: http://bugs.python.org/file31548/eol-patch.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Antoine Pitrou added the comment: Marking the files as binary (really don't touch) in .hgeol sounds reasonable to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Terry J. Reedy added the comment: Two things have happened with Python: we switched bytes from 'text or binary' to 'binary (or text)' in 3.0. We switched from svn to hg in 3.2. When did test_sax start failing? I have no idea. Until recently, there were much worse problems with the test suite on desktop windows; it sometimes quit before getting to 'sax'. Email and its tests (which had the same eol issue) were heavily revised in 3.3; I do not know if the test that failed in 3.3 failed earlier or not. Another failing email test was added in 3.4. David, Antoine: Tim questions/challenges the solution pushed in #12037. -- nosy: +pitrou, r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Serhiy Storchaka added the comment: Nit 2: why? The test passes as is. Currently test.xml and test.xml.out contain only ascii characters. But this can be changed in future. Actually I had added non-ascii characters to other test data and this had exposed some bugs in test suite. When did test_sax start failing? I have no idea. I guess it becomes after my commit in issue1470548 a half year ago. All proposed fixes are good enough. Feel free to commit what you prefers. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Tim Peters added the comment: test_email still passed on Windows under 3.2.5 (but test_sax failed). test_email and test_sax both fail under 3.3.2. I'll just push the change to .hgeol - minimally invasive, fixes the immediate problem, and it appears these really are binary files. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Terry J. Reedy added the comment: Having the files be the same on all systems seems the right solution. Changing .hgeol should do that, at least for the repository. Let's hope the Windows .msi installer leave line endings alone. I should install the a,b,c releases just to run the test suite with them. Side note: just above the quoted context in .hgeol is Lib/email/test/data/msg_26.txt = BIN which does not exist now. I suspect it should be removed as the obsolete old version of Lib/test/test_email/data/msg_26.txt = BIN which is in the quoted context. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Roundup Robot added the comment: New changeset 8efcf3c823f9 by Tim Peters in branch '3.3': Fix issue 18889: test_sax: multiple failures on Windows desktop. http://hg.python.org/cpython/rev/8efcf3c823f9 New changeset 25211a8b by Tim Peters in branch 'default': Merge fix from 3.3 into default. http://hg.python.org/cpython/rev/25211a8b -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Changes by Tim Peters t...@python.org: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Tim Peters added the comment: Terry, yes, the installer won't change line endings. I think - we'll find out for sure next time a release is cut - LOL ;-) Agreed that Lib/email/test/data/msg_26.txt is probably obsolete. Fix it, if you like! It's helpful to get rid of obsolete cruft. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
R. David Murray added the comment: For test_email, the fix was correct because the *test* didn't care about what line ending the source file had. I can't speak for sax. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Changes by Antoine Pitrou pit...@free.fr: -- components: +Tests stage: commit review - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Serhiy Storchaka added the comment: Why Lib/test/xmltestdata/test.xml.out contains '\r'? AFAIK Windows buildbots are happy with current tests. A nitpick for first proposed solution: you can append .replace(b'\r', b'') just to f.read(). A nitpick for second proposed solution: encoding should be iso-8859-1 (for both open() and encode()). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Terry J. Reedy added the comment: As I said on #12037, I would rather \r was not in the file. I do not know if it is present in the master repository or added by hg when cloning. Buildbots and developer desktops are different environments. The tests must work on both. Nit 1: right, I should have seen that. On #12037, I originally did the conversion in the test call. Nit 2: why? The test passes as is. Please pick a solution, test it on non-Windows if you can, and apply it so I can have the test suite pass on Windows after I apply a patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
New submission from Terry J. Reedy: These are due to \r in line endings, as with #12037. File F:\Python\dev\py34\lib\test\test_sax.py, line 634, in test_expat_file self.assertEqual(result.getvalue(), xml_test_out) Assert fails because off many \rs in xml_text_out. Same in line 649, in test_expat_file_nonascii line 778, in test_expat_inpsource_filename line 788, in test_expat_inpsource_sysid line 803, in test_expat_inpsource_sysid_nonascii line 816, in test_expat_inpsource_stream A fix that works is essentially the same as for #12037: xml_test_out = xml_test_out.replace(b'r', b'') just after xml_test_out is read from the file. (.translate(None, b'\r') also works, seems slightly slower) Another would be to not put \r in the file in the first place;-). Any objection to this? -- files: 188xx_text_sax.diff keywords: patch messages: 196606 nosy: christian.heimes, terry.reedy priority: normal severity: normal stage: commit review status: open title: test_sax: multiple failures on Windows desktop type: behavior versions: Python 3.3, Python 3.4 Added file: http://bugs.python.org/file31526/188xx_text_sax.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18889 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18889] test_sax: multiple failures on Windows desktop
Terry J. Reedy added the comment:
On #12037, David suggests instead the equivalent of this:
with open(TEST_XMLFILE_OUT) as f:
xml_test_out = f.read().encode('ascii')
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18889
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
