[issue18923] Use the new selectors module in the subprocess module
Roundup Robot added the comment: New changeset 71b618f0c8e9 by Charles-François Natali in branch 'default': Issue #18923: Update subprocess to use the new selectors module. http://hg.python.org/cpython/rev/71b618f0c8e9 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
Changes by Charles-François Natali cf.nat...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
Charles-François Natali added the comment: Here's an updated patch with a better logic: in the previous version - based on current poll-based implementation, the FD was inferred from the event (i.e. read ready - stdout/stderr, write ready - stderr). The new version directly checks the ready file object instead. I also added an extra safety in case an unknown FD is returned (which should never happen). -- nosy: +pitrou Added file: http://bugs.python.org/file32511/subprocess_selectors-3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
STINNER Victor added the comment: subprocess_selectors-3.diff looks good to me (this patch does not remove any test :-)) I created the issue #19506 for the memoryview optimization. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
Changes by Charles-François Natali cf.nat...@gmail.com: Added file: http://bugs.python.org/file32448/subprocess_selectors-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
Charles-François Natali added the comment: Here's an updated patch using the new selector.get_map() method. It removes ~100 lines to subprocess, which is always nice. -- Added file: http://bugs.python.org/file32429/subprocess_selectors-1.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
Charles-François Natali added the comment: Here's a patch updating subprocess to use selectors. (It depends on the new keys() method - issue #19172.) -- dependencies: +selectors: add keys() method keywords: +needs review, patch nosy: +neologix stage: - patch review Added file: http://bugs.python.org/file31966/subprocess_selectors.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- nosy: +giampaolo.rodola ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
Giampaolo Rodola' added the comment: It's likely that asyncore won't be able to take any practical advantage from this integration. To say one, epoll()/kqueue() pollers won't bring any speedup over select()/poll() because of how asyncore.loop() function is implemented (see http://bugs.python.org/issue6692#msg103628 and http://bugs.python.org/issue11273). Also, the new selectors module only takes read and write events into account, whereas asyncore explicitly closes dispatcher in case of disconnection events (POLLOUT, etc). In summary I'd say it's a lot wiser to leave asyncore alone and consider it frozen. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
New submission from STINNER Victor: Python 3.4 has a new selectors module (issue #16853). It would be nice to use it instead of select.poll or select.select in the subprocess module. -- messages: 196936 nosy: haypo priority: normal severity: normal status: open title: Use the new selectors module in the subprocess module type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18923] Use the new selectors module in the subprocess module
STINNER Victor added the comment: Other modules using select.select() or select.poll() for more than 1 file descriptor: - asyncore - multiprocessing.connection - multiprocessing.forkserver -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18923 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
