[issue18948] deliberately crashing tests should prevent core dumps
Roundup Robot added the comment: New changeset 1cbd3d9f7d61 by Antoine Pitrou in branch 'default': Issue #18948: improve SuppressCoreFiles to include Windows crash popup suppression, and use it in more tests. http://hg.python.org/cpython/rev/1cbd3d9f7d61 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Antoine Pitrou added the comment: Patch committed. Thanks to both of you! -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Zachary Ware added the comment: Here's a patch that combines Valerie's patch with a merged suppress_crash_popup and SuppressCoreFiles called SuppressCrashReport. Tests ok on Windows; I haven't been able to test on Unix yet. -- Added file: http://bugs.python.org/file31987/issue18948-combined.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Antoine Pitrou added the comment: Thanks! The patch works fine here under Linux, too (though I haven't tried to figure out if it really prevented core files from being generated). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
STINNER Victor added the comment: Perhaps it would be best to either combine SuppressCoreFiles and suppress_crash_popup Yes, these two tools must be merged into one unique portable tool. Example of names: * ignore_fatal_errors() * dont_report_crashes() * ignore_crashes() Doc: On Windows, don't display the Windows Error Reporting dialog. On UNIX, disable the creation of coredump file. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
STINNER Victor added the comment: test.support.SuppressCoreFiles was added by #18623. I implemented a similar tool in my tracemalloc fork: http://hg.python.org/features/tracemalloc/rev/b91450e51388 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Zachary Ware added the comment: Perhaps it would be best to either combine SuppressCoreFiles and suppress_crash_popup, or provide a new construct that does so since both are used in almost every place one is used. Also, test_daemon_threads_fatal_error in test_threading should be using suppress_crash_popup, but isn't currently, which I believe falls under the scope of this issue. -- nosy: +zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Valerie Lambert added the comment: Great! Thanks for putting together a list. I've incorporated SuppressCoreFiles into these tests and have used the test suite without any errors. Again, I'm testing these on Ubuntu. -- keywords: +patch Added file: http://bugs.python.org/file31743/issue-18948.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Antoine Pitrou added the comment: Ok, I've left a comment on the review tool above. You can click on the review link if you haven't received an e-mail. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Valerie Lambert added the comment: Oops! That was careless. Fixed. -- Added file: http://bugs.python.org/file31752/issue-18948_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
New submission from Antoine Pitrou: Here is a (exhaustive?) list of tests which deliberately crash the interpreter: - test_daemon_threads_fatal_error() in test_threading - several fatal error tests in test_faulthandler - test_recursionlimit_fatalerror() in test_sys - test_no_FatalError_infinite_loop() in test_capi They should reuse the new SuppressCoreFiles facility from test.support. -- components: Tests keywords: easy messages: 197090 nosy: lambertv, neologix, pitrou priority: low severity: normal stage: needs patch status: open title: deliberately crashing tests should prevent core dumps type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
