[issue19325] _osx_support imports many modules

[STINNER Victor]

STINNER Victor added the comment:

> FYI, issue29585 removes _osx_support dependency from site.py

Done: Lib/site.py doesn't import _osx_support anymore. So I close this issue.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[STINNER Victor]

Changes by STINNER Victor :


--
resolution: fixed -> out of date

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[INADA Naoki]

INADA Naoki added the comment:

FYI, issue29585 removes _osx_support dependency from site.py

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[Ronald Oussoren]

Ronald Oussoren added the comment:

The use of context lib in _read_output should not be necessary anymore as file 
objects and NamedTemporaryFile objects already are context managers with the 
right semantics. 

I'm not sure how to avoid the import of tempfile other than adding a minimal 
implementation of tempfile.mkstemp to _osx_support, in particular because the 
fallback code in _osx_support is insecure: It uses a named temporary file in 
/tmp with builtin.open and because the name of the file is predictable there is 
a small risk of overwriting arbitrary files when an attacker has access to 
/tmp. I guess the fallback is there to use during bootstrap, it should really 
be avoided afterwards. 

BTW. A small unscientific test on my laptop didn't see any differences between 
the regular _osx_support and a version where import re was moved inside the 
functions that use that module.  But: that's on a fast laptop with SSD for 
storage, there could easily be a difference on systems with slower storage.

Ned: do you remember what your idea was w.r.t. avoid the use of re? I guess its 
easy enough to replace the current re-using code by code that only uses str 
methods, but your phrasing seems to indicate another plan.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19325
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[Esa Peuha]

Esa Peuha added the comment:

Actually Lib/_osx_support.py directly imports only five modules: os, re and sys 
at top level, and contextlib and tempfile in _read_output(). These last two 
aren't really needed at all, and there's no point even trying to avoid 
importing os and sys, so the only real problem is re which imports lots of 
other modules. It might be possible to avoid using re (the regular expressions 
don't look very complicated) but I noticed that some functions are only ever 
called from distutils, so maybe they should be moved from _osx_support to 
distutils._osx_support before doing anything else. I'm willing to do that if 
it's considered a good idea.

--
nosy: +Esa.Peuha

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19325
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[Christian Heimes]

Christian Heimes added the comment:

For distutils function you can move the import of re inside the function body. 
It's not elegant but it does the trick w/o much slowdown or inconveniences.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19325
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[Ned Deily]

Ned Deily added the comment:

Yes, there are various tricks to be done.  I have another solution in mind that 
should eliminate the use re altogether for most cases.  (BTW, _osx_support was 
implemented to centralize functions in anticipation of the introduction of 
distutils2/packaging in Python 3.3, along with distutils.)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19325
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[Christian Heimes]

New submission from Christian Heimes:

On Mac OS X the site module imports sysconfig which imports _osx_support which 
in turn imports several more modules like the re module. More modules == slower 
startup. See #19205 for background information on the issue.

--
assignee: ronaldoussoren
components: Library (Lib), Macintosh
messages: 200733
nosy: christian.heimes, ronaldoussoren
priority: normal
severity: normal
stage: needs patch
status: open
title: _osx_support imports many modules
type: performance
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19325
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[STINNER Victor]

Changes by STINNER Victor victor.stin...@gmail.com:


--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19325
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19325] _osx_support imports many modules

[Ned Deily]

Changes by Ned Deily n...@acm.org:


--
assignee: ronaldoussoren - ned.deily
nosy: +ned.deily

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19325
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com