[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows
Zachary Ware added the comment: This appears to be back with slightly different line numbers: ..\Modules\_pickle.c(718): warning C4293: '' : shift count negative or too big, undefined behavior ..\Modules\_pickle.c(719): warning C4293: '' : shift count negative or too big, undefined behavior ..\Modules\_pickle.c(720): warning C4293: '' : shift count negative or too big, undefined behavior ..\Modules\_pickle.c(721): warning C4293: '' : shift count negative or too big, undefined behavior ..\Modules\_pickle.c(1647): warning C4146: unary minus operator applied to unsigned type, result still unsigned Seems to have been caused by 14f2776686b3. -- nosy: +zach.ware resolution: fixed - stage: committed/rejected - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19739 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows
Changes by Christian Heimes li...@cheimes.de: -- nosy: +christian.heimes ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19739 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows
Zachary Ware added the comment: The attached patch fixes the warnings and doesn't appear to break anything obvious. The first 4 are fixed by reverting Alexandre's change from '#if SIZEOF_SIZE_T' to 'if (sizeof(size_t)'. The last one is different from the original 5th warning, and is fixed using the same trick that has been used in Modules/audioop.c; that is, use '(-0x7fffL - 1)' rather than '-0x8000L', which MSVC can't seem to handle. -- keywords: +patch Added file: http://bugs.python.org/file32839/issue19739.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19739 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows
Roundup Robot added the comment: New changeset f8ac01a762c1 by Alexandre Vassalotti in branch 'default': Issue #19739: Try to fix compiler warnings on 32-bit Windows. http://hg.python.org/cpython/rev/f8ac01a762c1 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19739 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows
Alexandre Vassalotti added the comment: Thanks Zachary for the notice! Look like my change fixed the warnings on the Windows x86 build. http://buildbot.python.org/all/builders/x86%20Windows%20Server%202008%20%5BSB%5D%203.x/builds/1801 -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19739 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows
New submission from Tim Peters:
1..\Modules\_pickle.c(710): warning C4293: '' : shift count negative or too
big, undefined behavior
1..\Modules\_pickle.c(711): warning C4293: '' : shift count negative or too
big, undefined behavior
1..\Modules\_pickle.c(712): warning C4293: '' : shift count negative or too
big, undefined behavior
1..\Modules\_pickle.c(713): warning C4293: '' : shift count negative or too
big, undefined behavior
1..\Modules\_pickle.c(1158): warning C4018: '' : signed/unsigned mismatch
The first 4 should be easy to fix by using a SIZEOF_SIZE_T = 8 #ifdef test.
The last is on:
if (frame_len n) { ... raise an exception ...
where `frame_len` is size_t and `n` is Py_ssize_t.
--
assignee: alexandre.vassalotti
messages: 204084
nosy: alexandre.vassalotti, pitrou, tim.peters
priority: normal
severity: normal
status: open
title: Legit compiler warnings in new pickle code on 32-bit Windows
versions: Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19739
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows
Antoine Pitrou added the comment: Yes, there is actually a bug which shows up as errors in the tests. I'm currently testing a patch for it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19739 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows
Antoine Pitrou added the comment: I've fixed the first 4 in 458340ed0606 and the signed/unsigned warning in c3fd79b17983. -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19739 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
