[issue19771] runpy should check ImportError.name before wrapping it

[SilentGhost]

SilentGhost added the comment:

Martin, could you please escape * in Misc/NEWS, it causes a warning when 
building documentation.

--
nosy: +SilentGhost

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Martin Panter]

Martin Panter added the comment:

I think Serhiy just fixed this in revision ed2420379b8d, so it should be okay 
now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Roundup Robot]

Roundup Robot added the comment:

New changeset 850cc65ceda4 by Martin Panter in branch '3.5':
Issue #19771: Omit irrelevant message if package could not be initialized
https://hg.python.org/cpython/rev/850cc65ceda4

New changeset 323c10701e5d by Martin Panter in branch 'default':
Issue #19771: Merge runpy error adjustment from 3.5
https://hg.python.org/cpython/rev/323c10701e5d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Martin Panter]

Changes by Martin Panter :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Berker Peksag]

Changes by Berker Peksag :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Nick Coghlan]

Nick Coghlan added the comment:

The bad-pyc patch looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Martin Panter]

Martin Panter added the comment:

BTW I already applied the type(ex).__name__ fix in revision 3202d143a194.

New error message with this patch:

$ ./python -bWall -m bad_pyc
[. . .]/python: Error while finding spec for 'bad_pyc.__main__' (ImportError: 
bad magic number in 'bad_pyc': b'')

--
Added file: http://bugs.python.org/file41282/bad-pyc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Martin Panter]

Martin Panter added the comment:

I think I have fixed the original problem via Issue 14285 (fully in 3.5+, 
partly in 2.7). It involved a bit more than checking ImportError.name, because 
runpy catches other exceptions like AttributeError, which do not identify a 
module name.

That leaves Laura’s error with the bad *.pyc file. I propose bad-pyc.patch, 
which adds the sys.modules check to fix the error message, and adds a test 
case. I think this patch should be applicable to Python 2 as well.

--
versions: +Python 2.7 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Martin Panter]

Martin Panter added the comment:

Actually I forgot, this isn’t applicable to Python 2; see 
.

--
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Martin Panter]

Martin Panter added the comment:

My new patch for Issue 14285 should avoid the main problem. However there would 
still be at least one leftover minor fix worth appyling: fix the exception 
message to use type(ex).__name__, not repr(type(ex)).

--
dependencies: +Traceback wrong on ImportError while executing a package
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Laura Creighton]

Laura Creighton added the comment:

I tried to run some tests from  the python3.4 test suite and got:
python3 -m test -ugui test_tk test_ttk_guionly test_idle
/usr/bin/python3: Error while finding spec for 'test.__main__' (class 
'ImportError': bad magic number in 'test': b'\x03\xf3\r\n'); 'test' is a 
package and cannot be directly executed

The actual problem has nothing to do with test being a package.  It
had to do with finding a python2 pyc and trying to run that.  It would be nice 
if the patch checked for this problem as well before concluding that somebody 
just tried to execute a package.

--
nosy: +lac

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Martin Panter]

Martin Panter added the comment:

Posting a new patch with the following changes:

* Added Poleto’s original tests, updated according to review comments. Combined 
the flag and source code string parameters.

* Used a different approach to guessing where the offending ImportError came 
from. Now it checks if the module got added to sys.modules, which seems to work 
in all cases I tried. It no longer does what the bug title says (check 
ImportError.name), but I think it is a better workaround or fix for the 
underlying problem.

* Removed Poleto’s “Error executing package . . .” ImportError wrapper. We 
already know what package we are trying to execute, and it hasn’t actually been 
“executed” yet, because __init__.py failed.

* Cleaned up exception name in the “Error while finding spec” message

--
Added file: http://bugs.python.org/file38437/issue_19771_runpy.patch.v3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Martin Panter]

Martin Panter added the comment:

Closely related: Issue 14285, where an ImportError and various other exceptions 
caused by code in __init__.py are also incorrectly caught, trigger unexpected 
error messages, with no traceback being reported.

Not sure if checking the “name” attribute will help in even all of the most 
common cases, but it should be better than nothing. Another idea I had was 
checking if a module was inserted into sys.modules.

--
nosy: +vadmium

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +berker.peksag
stage: needs patch - patch review
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[R. David Murray]

R. David Murray added the comment:

Hmm.  It seems to me that .name not being set is a bug in importlib.  It 
appears that importlib doesn't set it in the 'from x import y' case.  After a 
bit of experimenting at the python prompt, I'm not even sure what that code in 
runpy is *doing* (find_spec('foo.__main__') seems to return None if __main__ 
doesn't exist but foo does).  I'm going to have to leave this to Nick unless I 
find some more time somewhere ;)

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Luiz Poleto]

Changes by Luiz Poleto luiz.pol...@gmail.com:


Added file: http://bugs.python.org/file34995/issue_19771.patch.v2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Luiz Poleto]

Luiz Poleto added the comment:

The attached patch provide test cases to validate this error. As noted by R. 
David Murray in a discussion in the Core-Mentorship list, this error in fact 
happens then __init__.py throws an ImportError.

--
keywords: +patch
nosy: +poleto
Added file: http://bugs.python.org/file34988/issue_19771_tests.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Luiz Poleto]

Luiz Poleto added the comment:

As suggested by Nick, the fix is done be verifying the name attribute of the 
raised ImportError exception; the exception is then re-raised with the 
appropriate description.

--
Added file: http://bugs.python.org/file34989/issue_19771.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Eric Snow]

Changes by Eric Snow ericsnowcurren...@gmail.com:


--
nosy: +eric.snow

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Anthony Kong]

Changes by Anthony Kong anthony.hw.k...@gmail.com:


--
nosy: +Anthony.Kong

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Fotis Koutoulakis]

Fotis Koutoulakis added the comment:

Hello, I'm in the process of trying to find a solution to this problem, but I'm 
afraid the choice of wording at some point is kind of...ambiguous.

I have some questions I want to ask, to clear some doubts in my head:

First one is: 

if __main__ in a package throws ImportError, runpy will incorrectly report the 
package as not being directly executable (when it actually claims to be 
executable, it's just broken)

In the above, from what I can understand from the first part of the sentence, 
before the paragraph, if __main__.py is not found in a package, run py will 
report that it won't be directly executable. Along these lines, it's mentioned 
that this behaviour is incorrect, but then the sentence inside the parentheses 
contradicts that position, suggesting that when it does suggest it's actually 
executable, it's just erroneous behaviour (so both behaviours are erroneous?)

The second one is:

This can be fixed in 3.3+ by checking for an appropriate value in the name 
attribute of the caught exception, and only wrapping it if the failed lookup 
was for the __main__ submodule we're looking for.

Ok this seems to be pretty clear, we are expected to create a new package with 
a __main__.py that all it does is `raise ImportError`. (Disclaimer: I may be 
fairly wrong here). Question is, where should we put the new package? 
Obviously, we shouldn't litter the real modules, with the testing one, but if 
I try to use the test folder as a package, I get ImportError: error while 
finding loader for xxx

Please be lenient with me, this is one of my very first contributions to 
python. I will gladly accept all feedback.

--
nosy: +Fotis.Koutoulakis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Nick Coghlan]

Nick Coghlan added the comment:

By providing a __main__.py submodule, a package is saying I am directly 
executable. When runpy says it isn't (because running that file happened to 
raise ImportError), then runpy is wrong.

runpy can't make the file work (it's genuinely broken), but it can avoid 
reporting a misleading error message - that's the bug to be fixed.

As far as the testing goes, if you look at the existing runpy tests, the usual 
approach is to create a temporary directory, write out a package with the 
desired behaviour, and then run it from there. So, for this test, it's a matter 
of copying the general structure of the existing package execution test in 
test_runpy, but replacing the body of the __main__.py file with something like 
raise ImportError('This should not be replaced')

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19771] runpy should check ImportError.name before wrapping it

[Nick Coghlan]

New submission from Nick Coghlan:

Issue 19769 shows that if __main__ in a package throws ImportError, runpy will 
incorrectly report the package as not being directly executable (when it 
actually claims to be executable, it's just broken)

This can be fixed in 3.3+ by checking for an appropriate value in the name 
attribute of the caught exception, and only wrapping it if the failed lookup 
was for the __main__ submodule we're looking for.

The associated test can just use a __main__.py that deliberately raises 
ImportError.

--
components: Library (Lib)
keywords: easy
messages: 204334
nosy: ncoghlan
priority: normal
severity: normal
stage: needs patch
status: open
title: runpy should check ImportError.name before wrapping it
type: behavior
versions: Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19771
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com