[issue20137] Logging: RotatingFileHandler computes string length instead of byte representation length.
A. Libotean added the comment: Which encoding are you using, such that the difference in length between encoded and decoded messages is significant? I agree right off the bat that the error in size is not significant. Only the length of the last appended line is computed erroneously. I'm uploading the patch in case you decide to apply it. Thanks. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20137 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20137] Logging: RotatingFileHandler computes string length instead of byte representation length.
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- resolution: - invalid status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20137 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20137] Logging: RotatingFileHandler computes string length instead of byte representation length.
A. Libotean added the comment: Sure, will come back shortly with a patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20137 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20137] Logging: RotatingFileHandler computes string length instead of byte representation length.
Vinay Sajip added the comment: Which encoding are you using, such that the difference in length between encoded and decoded messages is significant? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20137 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20137] Logging: RotatingFileHandler computes string length instead of byte representation length.
New submission from A. Libotean: Current implementation of RotatingFileHandler ignores the encoding when computing the entry byte length. I've attached a modified version that will compute the entry lenght in bytes. -- components: Library (Lib) files: rotatingfilehandler.py messages: 207417 nosy: alibotean priority: normal severity: normal status: open title: Logging: RotatingFileHandler computes string length instead of byte representation length. type: behavior versions: Python 2.7 Added file: http://bugs.python.org/file33322/rotatingfilehandler.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20137 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20137] Logging: RotatingFileHandler computes string length instead of byte representation length.
R. David Murray added the comment: Could you please upload your proposed fix as a patch file (universal diff)? -- nosy: +r.david.murray, vinay.sajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20137 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
