[issue20157] Argument Clinic generates wrong keyword parameter name for default

2014-01-07 Thread Serhiy Storchaka 

New submission from Serhiy Storchaka:

For the default keyword parameter Argument Clinic generates wrong name 
default_value in the _keywords array.

/*[clinic]
module spam
spam.ham

default: int = 1

[clinic]*/

...

static PyObject *
spam_ham(PyModuleDef *module, PyObject *args, PyObject *kwargs)
{
PyObject *return_value = NULL;
static char *_keywords[] = {default_value, NULL};
int default_value = 1;

if (!PyArg_ParseTupleAndKeywords(args, kwargs,
|i:ham, _keywords,
default_value))
goto exit;
...

--
components: Build
files: spammodule.c
messages: 207513
nosy: larry, serhiy.storchaka
priority: release blocker
severity: normal
stage: needs patch
status: open
title: Argument Clinic generates wrong keyword parameter name for default
type: behavior
versions: Python 3.4
Added file: http://bugs.python.org/file7/spammodule.c

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20157
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20157] Argument Clinic generates wrong keyword parameter name for default

2014-01-07 Thread Larry Hastings 

Larry Hastings added the comment:

I'll fix this but it's low priority for today.

It's not a release blocker; we could release Python 3.4 with this bug.

--
assignee:  - larry
priority: release blocker - normal

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20157
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20157] Argument Clinic generates wrong keyword parameter name for default

2014-01-07 Thread Larry Hastings 

Larry Hastings added the comment:

The problem was an easy fix.  However, while fixing it I discovered another 
problem (if [clinic]*/ was the last line, and it didn't have an eol, Clinic 
would append another [clinic]*/).  I fixed that too and added a regression 
test.

Okay?

--
Added file: 
http://bugs.python.org/file33346/larry.clinic.keyword.renamer.diff.1.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20157
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20157] Argument Clinic generates wrong keyword parameter name for default

2014-01-07 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset f61c63ec4e70 by Larry Hastings in branch 'default':
Issue #20157: When Argument Clinic renames a parameter because its name
http://hg.python.org/cpython/rev/f61c63ec4e70

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20157
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20157] Argument Clinic generates wrong keyword parameter name for default

2014-01-07 Thread Larry Hastings 

Changes by Larry Hastings la...@hastings.org:


--
resolution:  - fixed
stage: needs patch - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20157
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com