[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Larry Hastings added the comment: Steve, please close this issue when you've confirmed it's now building correctly on Windows. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Steve Dower added the comment: LGTM -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Roundup Robot added the comment: New changeset 7a76c462c7f6 by Larry Hastings in branch 'default': Fix Windows build breakage from checkins on Issues #20148 and #20168. https://hg.python.org/cpython/rev/7a76c462c7f6 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Serhiy Storchaka added the comment: wantobjects() was not converted due to a bug in Argument Clinic (issue24051). -- dependencies: -Argument Clinic no longer works with single optional argument resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Roundup Robot added the comment: New changeset b22ced894d51 by Serhiy Storchaka in branch 'default': Issue #20168: Converted the _tkinter module to Argument Clinic. https://hg.python.org/cpython/rev/b22ced894d51 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Steve Dower added the comment: This broke Windows builds because of unnecessary static qualifiers on the forward declarations at lines 2685 and 3006 (as discussed on #20323). Removing static from these lines fixes the build. -- nosy: +steve.dower resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Larry Hastings added the comment: As mentioned on #20148, removing the static from the forward declarations breaks it on GCC. (And, of the two, I think GCC is the one being reasonable here.) Attached is a patch that should fix the build for tkinter. -- Added file: http://bugs.python.org/file39282/larry.fix.tkinter.build.on.windows.diff.1.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Argument Clinic no longer works with single optional argument ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file39089/tkinter_4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file39091/tkinter_4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Serhiy Storchaka added the comment: Updated to the tip. Converted methods getint, getdouble, getboolean, splitlist, split. -- Added file: http://bugs.python.org/file39089/tkinter_4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Argument Clinic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Serhiy Storchaka added the comment: Synchronized with tip. -- Added file: http://bugs.python.org/file35437/tkinter_clinic_3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Serhiy Storchaka added the comment: Here is updated patch. -- versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file34533/tkinter_clinic_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Serhiy Storchaka added the comment: Here is a patch. -- keywords: +patch nosy: +gpolo stage: - patch review Added file: http://bugs.python.org/file33528/tkinter_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Larry Hastings added the comment: So do you think there are any entry points worth converting in _tkinter, or should we close this issue? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Serhiy Storchaka added the comment: You misunderstood me. I already have 1018-lines patch which converts about 24 functions and methods to Argument Clinic church. And I'm working on left functions. Do you want to get unfinished patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Larry Hastings added the comment: Oh, okay. That sounds fine, and I'm not in a hurry. Please post the patch whenever you're ready, thanks! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: -- dependencies: +Argument Clinic generates invalid code for optional parameter ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
New submission from Serhiy Storchaka: In progress. Actually many functions are not very suitable for Argument Clinic. -- components: Extension Modules, Tkinter messages: 207600 nosy: serhiy.storchaka priority: normal severity: normal status: open title: Derby: Convert the _tkinter module to use Argument Clinic type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka nosy: +larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Changes by Jeremy Kloth jeremy.kloth+python-trac...@gmail.com: -- nosy: +jkloth ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Larry Hastings added the comment: What functions, and what makes them unsuitable? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Serhiy Storchaka added the comment: call() just converts all args to Tcl list. Is Argument Clinic supports *args and **kwargs? I'm not sure there is a benefit with using Argument Clinic here. splitlist() and split() first call PyArg_ParseTuple with one argument, check the input, and then may call PyArg_ParseTuple with other argument. They need large refactoring to use Argument Clinic. getint(), getdouble(), getboolean() first manually unpack arguments tuple, and then may call PyArg_ParseTuple. Same as above. setvar()/globalsetvar(), getvar()/globalgetvar(), unsetvar()/globalunsetvar() shares common code parametrized by flags. I think this is resolvable. But worse, they can delegates their execution to other thread and should save all arguments in events queue. And this looks absolutely unsuitable for Argument Clinic. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20168] Derby: Convert the _tkinter module to use Argument Clinic
Larry Hastings added the comment: (It would have made it easier on me if you'd used the C function names, instead of the names in the module.) I agree. In retrospect, it's not surprising that things in _tkinter aren't suitable, as it appears to be a shunt for calling things in Tcl. For what it's worth, Argument Clinic is only intended for functions that use PyArg_ParseTuple or PyArg_ParseTupleOrKeywords to parse their arguments. So something like call is and will forever be unsuitable. (And reading _tkinter.c this has reminded me why I don't like Tcl ;-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20168 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
