[issue20395] Extract generated clinic code in Modules/_pickle.c to separate file
Roundup Robot added the comment: New changeset 1aa8ea187560 by Serhiy Storchaka in branch 'default': Issue #20395: Extract generated clinic code in Modules/_pickle.c to separate file. http://hg.python.org/cpython/rev/1aa8ea187560 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20395 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20395] Extract generated clinic code in Modules/_pickle.c to separate file
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20395 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20395] Extract generated clinic code in Modules/_pickle.c to separate file
New submission from Serhiy Storchaka: Argument Clinic had added about half-thousand lines of code to Modules/_pickle.c. This generated code is mixed with handwritten code. Last 8 changes of Modules/_pickle.c are caused by Argument Clinic evolution, and I afraid that many future Argument Clinic changes will change Modules/_pickle.c too. The proposed patch extracts generated clinic code in separate file to prevent or decrease code churn in future. It decreases the size of Modules/_pickle.c by 450 lines. -- files: pickle_clinic.patch keywords: patch messages: 209293 nosy: alexandre.vassalotti, larry, pitrou, serhiy.storchaka priority: normal severity: normal stage: patch review status: open title: Extract generated clinic code in Modules/_pickle.c to separate file versions: Python 3.4 Added file: http://bugs.python.org/file33722/pickle_clinic.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20395 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20395] Extract generated clinic code in Modules/_pickle.c to separate file
Larry Hastings added the comment: Alexandre: We're still figuring out best practices with Argument Clinic. So, right now, there's no standard policy of where should we put all the generated code?, and we're leaving it up to the owners of the individual modules. Putting it in a second file and #including it is a popular option, but there are other options too (and Guido says he hates code generators that put stuff in a second file). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20395 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20395] Extract generated clinic code in Modules/_pickle.c to separate file
Antoine Pitrou added the comment: +1 for a separate file from me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20395 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20395] Extract generated clinic code in Modules/_pickle.c to separate file
Alexandre Vassalotti added the comment: +1 from me as well for a separate file. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20395 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
