[issue20422] Signature.from_builtin should raise a ValueError when no signature can be provided
Nick Coghlan added the comment:
This proposal and patch look good to me. The current behaviour definitely isn't
desirable:
import inspect
inspect.Signature.from_function(1)
Traceback (most recent call last):
File stdin, line 1, in module
File /home/ncoghlan/devel/py3k/Lib/inspect.py, line 1888, in from_function
raise TypeError('{!r} is not a Python function'.format(func))
TypeError: 1 is not a Python function
inspect.Signature.from_builtin(1)
Signature.from_function() and Signature.from_builtin() should both also be
documented, but we may want to wait for PEP 457 and #17373 in Python 3.5 before
sorting all that out.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20422
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20422] Signature.from_builtin should raise a ValueError when no signature can be provided
Yury Selivanov added the comment: Nick, thanks for the review. Committed. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20422 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20422] Signature.from_builtin should raise a ValueError when no signature can be provided
Yury Selivanov added the comment: Signature.from_function() and Signature.from_builtin() should both also be documented, but we may want to wait for PEP 457 and #17373 in Python 3.5 before sorting all that out. I would like to wait till 3.5 too. Right now both of them are sort of private API, so we still have the liberty to adjust their behaviour in 3.5 if needed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20422 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20422] Signature.from_builtin should raise a ValueError when no signature can be provided
Roundup Robot added the comment: New changeset 9433b380ad33 by Yury Selivanov in branch 'default': inspect.Signature: Make from_builtin to raise an exception if no signature can http://hg.python.org/cpython/rev/9433b380ad33 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20422 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20422] Signature.from_builtin should raise a ValueError when no signature can be provided
New submission from Yury Selivanov: Right now it may return `None` if no signature can be returned for the given builtin. If we decide to implement #17373 in 3.5, I'd like all three methods -- from_builtin, from_function, from_callable -- to either return a signature or to raise an exception. -- messages: 209565 nosy: brett.cannon, larry, ncoghlan, yselivanov priority: normal severity: normal status: open title: Signature.from_builtin should raise a ValueError when no signature can be provided type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20422 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20422] Signature.from_builtin should raise a ValueError when no signature can be provided
Yury Selivanov added the comment: A patch is attached, please review. -- keywords: +needs review, patch stage: - patch review Added file: http://bugs.python.org/file33784/from_builtin_errors_01.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20422 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
