[issue20440] Use the Py_SETREF macro

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The commit doesn't include changes for dictobject.c, setobject.c and 
_sqlite/cache.c (I had forgot to exclude them from the patch before uploading). 
Dict and set code is performance critical, and using Py_XDECREF instead of 
Py_DECREF can affect performance. The code in _sqlite would use Py_SETREF in 
less obvious way, it is better to left it as is.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1118dfcbcc35 by Serhiy Storchaka in branch 'default':
Issue #20440: Cleaning up the code by using Py_SETREF.
https://hg.python.org/cpython/rev/1118dfcbcc35

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The final patch replaces the code that equivalent to the Py_SETREF macro by 
using the Py_SETREF macro. There are no bugs, the patch only makes the correct 
code cleaner. If I'll not got a review, I'll just close this issue.

--
versions:  -Python 2.7, Python 3.5
Added file: http://bugs.python.org/file41505/py_setref_extra3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Roundup Robot]

Roundup Robot added the comment:

New changeset e04cd497aa41 by Zachary Ware in branch 'default':
Issue #25972, #20440: Fix compilation on Windows
https://hg.python.org/cpython/rev/e04cd497aa41

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Roundup Robot]

Roundup Robot added the comment:

New changeset 9fb57c0209ea by Serhiy Storchaka in branch '3.5':
Issue #20440: Applied yet one patch for using Py_SETREF.
https://hg.python.org/cpython/rev/9fb57c0209ea

New changeset bc7c56a225de by Serhiy Storchaka in branch 'default':
Issue #20440: Applied yet one patch for using Py_SETREF.
https://hg.python.org/cpython/rev/bc7c56a225de

New changeset e6502bf289ab by Serhiy Storchaka in branch '2.7':
Issue #20440: Applied yet one patch for using Py_SETREF.
https://hg.python.org/cpython/rev/e6502bf289ab

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file41430/py_setref_extra2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4bfbb2714ae9 by Serhiy Storchaka in branch '3.5':
Issue #20440: More use of Py_SETREF.
https://hg.python.org/cpython/rev/4bfbb2714ae9

New changeset 11670e4be1a9 by Serhiy Storchaka in branch '2.7':
Issue #20440: More use of Py_SETREF.
https://hg.python.org/cpython/rev/11670e4be1a9

New changeset 539ba7267701 by Serhiy Storchaka in branch 'default':
Issue #20440: More use of Py_SETREF.
https://hg.python.org/cpython/rev/539ba7267701

New changeset b02d256b8827 by Serhiy Storchaka in branch 'default':
Issue #20440: Cleaning up the code by using Py_SETREF and Py_CLEAR.
https://hg.python.org/cpython/rev/b02d256b8827

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Roundup Robot]

Roundup Robot added the comment:

New changeset 23296440b654 by Serhiy Storchaka in branch '2.7':
Issue #20440: Massive replacing unsafe attribute setting code with special
https://hg.python.org/cpython/rev/23296440b654

New changeset fd36d72f6030 by Serhiy Storchaka in branch '3.5':
Issue #20440: Massive replacing unsafe attribute setting code with special
https://hg.python.org/cpython/rev/fd36d72f6030

New changeset c4e8751ce637 by Serhiy Storchaka in branch 'default':
Issue #20440: Massive replacing unsafe attribute setting code with special
https://hg.python.org/cpython/rev/c4e8751ce637

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Committed patches were generated with attached Coccinelle script.

--
Added file: http://bugs.python.org/file41401/py_setref.cocci

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Following patch is manually crafted and covers the rest cases. It also replaces 
existing correct attribute replacing using a temporary variable with more 
compact call of the macro.

--
Added file: http://bugs.python.org/file41402/py_setref_extra.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20440] Use the Py_SETREF macro

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
title: Use Py_REPLACE/Py_XREPLACE macros -> Use the Py_SETREF macro

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com