[issue20474] test_socket failures on OS X due to fixed expected failures

[Roundup Robot]

Roundup Robot added the comment:

New changeset 63efacd80f8e by Ned Deily in branch '3.3':
Issue #20474: Fix unexpected success test_socket failures on OS X 10.7+.
http://hg.python.org/cpython/rev/63efacd80f8e

New changeset 036671354dc0 by Ned Deily in branch 'default':
Issue #20474: Fix unexpected success test_socket failures on OS X 10.7+.
http://hg.python.org/cpython/rev/036671354dc0

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20474
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20474] test_socket failures on OS X due to fixed expected failures

[Ned Deily]

Changes by Ned Deily n...@acm.org:


--
assignee:  - ned.deily
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20474
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20474] test_socket failures on OS X due to fixed expected failures

[Ned Deily]

New submission from Ned Deily:

Three send timeout test cases in test_socket were changed by a4e4facad164 for 
Issue12958 to be expected failures on OS X because of observed failures on 
the OS X buildbots running OS X 10.6 (Snow Leopard) and earlier.

testInterruptedSendTimeout (test.test_socket.InterruptedSendTimeoutTest) ... 
unexpected success
testInterruptedSendmsgTimeout (test.test_socket.InterruptedSendTimeoutTest) ... 
unexpected success
testInterruptedSendtoTimeout (test.test_socket.InterruptedSendTimeoutTest) ... 
unexpected success

It seems that the platform bugs causing the failures were fixed in OS X 10.7 so 
that the expected failures no longer fail.  However, the change in behavior 
had not been noticed because, until the recent change to unittest in 
Issue20165, unittest did not fail when there were unexpected successes.  Now it 
does fail, causing test_socket to fail on OS X 10.7+ for 3.4.  On 3.3 the 
unexpected success failures are silently skipped.  The attached patch changes 
the test cases to be skipped for OS X versions prior to 10.7 rather than to 
always expect failure on OS X.

--
components: Tests
messages: 209882
nosy: larry, ncoghlan, ned.deily
priority: high
severity: normal
stage: patch review
status: open
title: test_socket failures on OS X due to fixed expected failures
versions: Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20474
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20474] test_socket failures on OS X due to fixed expected failures

[Ned Deily]

Changes by Ned Deily n...@acm.org:


--
keywords: +patch
Added file: http://bugs.python.org/file33842/issue20474.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20474
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20474] test_socket failures on OS X due to fixed expected failures

[Ned Deily]

Changes by Ned Deily n...@acm.org:


Added file: http://bugs.python.org/file33843/issue20474.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20474
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20474] test_socket failures on OS X due to fixed expected failures

[Ned Deily]

Changes by Ned Deily n...@acm.org:


Removed file: http://bugs.python.org/file33842/issue20474.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20474
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com