[issue21242] Generalize configure check for working Python executable

[Brett Cannon]

Change by Brett Cannon :


--
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21242] Generalize configure check for working Python executable

[Brett Cannon]

Brett Cannon  added the comment:

`make regen-all` has probably taken care of this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21242] Generalize configure check for working Python executable

[Martin Panter]

Martin Panter added the comment:

It is still not clear what change you were proposing. Perhaps factor out the 
common code for ADSLGEN and OPCODEHGEN? If so, that has been done as part of 
Issue 26662 in 3.5+.

--
nosy: +martin.panter
superseder:  -> configure/Makefile doesn't check if "python" command works, 
needed to build Objects/typeslots.inc

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21242] Generalize configure check for working Python executable

[Brett Cannon]

New submission from Brett Cannon:

configure.ac has a check that sets ASDLGEN based on what Python interpreter to 
use for running various scripts which generate files related to the AST. It 
probably should be generalized so that there's only one check for any script 
usage in Makefile.pre.in since there is really no need to check multiple times 
for the same thing.

--
components: Build
messages: 216346
nosy: brett.cannon, kushal.das
priority: low
severity: normal
stage: needs patch
status: open
title: Generalize configure check for working Python executable
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21242
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21242] Generalize configure check for working Python executable

[Meador Inge]

Meador Inge added the comment:

I am not sure I follow.  In configure.ac I see one check for Python:

  AC_SUBST(ASDLGEN)
  AC_CHECK_PROGS(PYTHON, python$PACKAGE_VERSION python3 python, not-found)
  if test $PYTHON = not-found; then
  ASDLGEN=@echo python: $PYTHON! cannot run \$(srcdir)/Parser/asdl_c.py #
  else
  ASDLGEN=$PYTHON
  fi

and a couple of uses for it in Makefile.pre.in:

  $(AST_H): $(AST_ASDL) $(ASDLGEN_FILES)
  $(MKDIR_P) $(AST_H_DIR)
  $(ASDLGEN) -h $(AST_H_DIR) $(AST_ASDL)

  $(AST_C): $(AST_H) $(AST_ASDL) $(ASDLGEN_FILES)
  $(MKDIR_P) $(AST_C_DIR)
  $(ASDLGEN) -c $(AST_C_DIR) $(AST_ASDL)

Are you suggesting that the variable name 'ASDLGEN be renamed to something 
more general so that any scripts that need to be run *before* building the 
interpreter can use it?

I don't see any other AC_CHECK_PROGS checks for Python in configure.ac.

Apologies if I am being dense today :-)

--
nosy: +meador.inge

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21242
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21242] Generalize configure check for working Python executable

[Meador Inge]

Meador Inge added the comment:

Ah, okay, this looks in reference to the opcode generation stuff in issue17861.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21242
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21242] Generalize configure check for working Python executable

[Brett Cannon]

Brett Cannon added the comment:

You figured out the reason for the interest; I filed the bug faster than Kushal 
could commit his code. =)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21242
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com