[issue21357] Increase filecmp test coverage from 63% to 76%

2014-05-03 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 57dacba9febf by Benjamin Peterson in branch '3.4':
improve test coverage of filecmp (closes #21357)
http://hg.python.org/cpython/rev/57dacba9febf

New changeset c597654a7fd8 by Benjamin Peterson in branch 'default':
merge 3.4 (#21357)
http://hg.python.org/cpython/rev/c597654a7fd8

--
nosy: +python-dev
resolution:  - fixed
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21357
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21357] Increase filecmp test coverage from 63% to 76%

2014-04-26 Thread diana 

New submission from diana:

- Increase filecmp test coverage from 63% to 76%

- I left the testing style as-is, though it could probably be modernized.

- I did not attempt to add coverage for 'funny_files', 'subdirs', etc, next 
pass perhaps.

- Before:

diana$ ./python.exe ../coveragepy report --show-missing
Name  Stmts   Miss  Cover   Missing
---
Lib/filecmp 163 6163%   64, 80, 126, 130, 159-161, 164-166, 172, 
174, 178-180, 190-194, 197-199, 203-224, 227-230, 233-236, 246, 293-302, 305

- After:

diana$ ./python.exe ../coveragepy report --show-missing
Name  Stmts   Miss  Cover   Missing
---
Lib/filecmp 163 3976%   64, 80, 126, 130, 159-161, 164-166, 172, 
174, 178-180, 192-194, 197-199, 217-218, 220-221, 223-224, 229-230, 235-236, 
246, 293-302, 305

Thoughts? Thanks!

--
components: Library (Lib)
files: increase_filecmp_test_coverage.patch
keywords: patch
messages: 217201
nosy: diana
priority: normal
severity: normal
status: open
title: Increase filecmp test coverage from 63% to 76%
type: behavior
versions: Python 3.5
Added file: 
http://bugs.python.org/file35045/increase_filecmp_test_coverage.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21357
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21357] Increase filecmp test coverage from 63% to 76%

2014-04-26 Thread Antoine Pitrou 

Changes by Antoine Pitrou pit...@free.fr:


--
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21357
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21357] Increase filecmp test coverage from 63% to 76%

2014-04-26 Thread Éric Araujo 

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21357
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21357] Increase filecmp test coverage from 63% to 76%

2014-04-26 Thread Benjamin Peterson 

Benjamin Peterson added the comment:

Thanks for the patch. I think you could use the support.catpured_stdout() 
context-manager in _assert_report. You should also sign the contributor 
agreement.

--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21357
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21357] Increase filecmp test coverage from 63% to 76%

2014-04-26 Thread diana 

Changes by diana diana.joan.cla...@gmail.com:


Added file: 
http://bugs.python.org/file35046/increase_filecmp_test_coverage_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21357
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21357] Increase filecmp test coverage from 63% to 76%

2014-04-26 Thread diana 

Changes by diana diana.joan.cla...@gmail.com:


Removed file: 
http://bugs.python.org/file35046/increase_filecmp_test_coverage_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21357
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21357] Increase filecmp test coverage from 63% to 76%

2014-04-26 Thread diana 

diana added the comment:

Nice, the support.catpured_stdout() context manager is much better.

I've added a new patch with that change:

increase_filecmp_test_coverage__updated_to_use_context_manager.patch

Thanks for reviewing this, Benjamin!

PS. I signed the contributor agreement.

--
Added file: 
http://bugs.python.org/file35047/increase_filecmp_test_coverage__updated_to_use_context_manager.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21357
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com