[issue21391] PATCH: using the abspath shortcut in Lib/shutil

2014-05-02 Thread Éric Araujo 

Éric Araujo added the comment:

IMO either change would not improve the code at all.  Suggest closing this.

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21391] PATCH: using the abspath shortcut in Lib/shutil

2014-05-02 Thread Eric V. Smith 

Eric V. Smith added the comment:

I disagree. It took me longer than I'd like to admit to track down the file 
history and understand it. I'd like to prevent other people from having to try 
and understand why it works this way.

On the other hand, it looks like people have discovered it:
https://mail.python.org/pipermail/tutor/2012-August/090891.html
so getting rid of it isn't so simple.

If we are going to keep it, we should add a test for it (which actually might 
exist, I haven't checked yet).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21391] PATCH: using the abspath shortcut in Lib/shutil

2014-05-01 Thread Yinon Ehrlich 

Yinon Ehrlich added the comment:

Use the 'abspath' shortcut instead of 'os.path.abspath'
See the attached patch (sorry, forgot to attach before)

--
keywords: +patch
Added file: http://bugs.python.org/file35126/shutil.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21391] PATCH: using the abspath shortcut in Lib/shutil

2014-05-01 Thread Eric V. Smith 

Eric V. Smith added the comment:

Wouldn't it be better to switch uses of abspath to be os.path.abspath? os.path 
is used elsewhere in the file, after all.

Brett added from os.path import abspath in 
http://hg.python.org/cpython/rev/686e5d38be42 but I think that import should be 
deleted and os.path.abspath used directly.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21391] PATCH: using the abspath shortcut in Lib/shutil

2014-05-01 Thread Eric V. Smith 

Changes by Eric V. Smith e...@trueblade.com:


--
stage:  - patch review
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21391] PATCH: using the abspath shortcut in Lib/shutil

2014-04-30 Thread Yinon Ehrlich 

Changes by Yinon Ehrlich yino...@users.sourceforge.net:


--
components: Library (Lib)
nosy: Yinon
priority: normal
severity: normal
status: open
title: PATCH: using the abspath shortcut in Lib/shutil
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21391] PATCH: using the abspath shortcut in Lib/shutil

2014-04-30 Thread Eric V. Smith 

New submission from Eric V. Smith:

If you meant to supply a patch, it is missing. And in any event, you need to 
describe the issue.

--
nosy: +eric.smith

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com