[issue21442] Win32 compiler warning in PyBytes_Concat
Zachary Ware added the comment: Declaring oldsize as Py_ssize_t instead of size_t at Objects/bytesobject.c:2812 takes care of the warning, but I'm not comfortable saying that's a correct change. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21442 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21442] Win32 compiler warning in PyBytes_Concat
Changes by Zachary Ware zachary.w...@gmail.com: -- nosy: +tim.golden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21442 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21442] Win32 compiler warning in PyBytes_Concat
Tim Golden added the comment: Well PyBytes_GET_SIZE is documented as returning a Py_ssize_t so I'd say it's perfectly valid. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21442 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21442] Win32 compiler warning in PyBytes_Concat
Roundup Robot added the comment: New changeset 6234f4caba57 by Zachary Ware in branch 'default': Issue #21442: Fix MSVC compiler warning introduced by issue21377. http://hg.python.org/cpython/rev/6234f4caba57 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21442 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21442] Win32 compiler warning in PyBytes_Concat
Zachary Ware added the comment: I should have looked a little harder, thanks Tim! -- assignee: - zach.ware resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21442 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21442] Win32 compiler warning in PyBytes_Concat
New submission from Zachary Ware: Issue #21377 introduced a compiler warning on Windows: ..\Objects\bytesobject.c(2824): warning C4018: '' : signed/unsigned mismatch [P:\ath\to\cpython\PCbuild\pythoncore.vcxproj] -- components: Build, Windows messages: 217942 nosy: haypo, nikratio, pitrou, zach.ware priority: normal severity: normal stage: needs patch status: open title: Win32 compiler warning in PyBytes_Concat type: behavior versions: Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21442 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
