[issue21488] codecs.encode/decode documentation inconsistency
Nick Coghlan added the comment: Brett, if you granted Berker commit privileges, you forgot to update the developer log and issue tracker... That said, the patch LGTM too. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
STINNER Victor added the comment: For Python 3.5, I would prefer to patch the code to support keywords instead. -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
STINNER Victor added the comment: I sent a review on Rietveld. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
STINNER Victor added the comment: codecs_decode_encode_kw.patch: Patch for Python 3.5 adding support of keyword arguments on codecs.encode and codecs.decode. -- Added file: http://bugs.python.org/file35250/codecs_decode_encode_kw.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
Brett Cannon added the comment: Nope, I forgot Berker had triage rights but not commit rights. -- assignee: berker.peksag - docs@python ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
Roundup Robot added the comment: New changeset cc5e3b93c35a by Victor Stinner in branch '2.7': Issue #21488: Fix doc of codecs.decode() and codecs.encode(), no keyword support. http://hg.python.org/cpython/rev/cc5e3b93c35a New changeset 2e116176a81f by Victor Stinner in branch '3.4': Issue #21488: Fix doc of codecs.decode() and codecs.encode(), no keyword support. http://hg.python.org/cpython/rev/2e116176a81f New changeset 889896471498 by Victor Stinner in branch 'default': Merge 3.4: ignore change specific to 3.4 for #21488, I had a different patch for Python 3.5 http://hg.python.org/cpython/rev/889896471498 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
Roundup Robot added the comment: New changeset 6ceedbd88b5f by Victor Stinner in branch '3.4': Issue #21488: Add support of keyword arguments for codecs.encode and codecs.decode http://hg.python.org/cpython/rev/6ceedbd88b5f -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
STINNER Victor added the comment: I applied all patches and added Brad Aylsworth to Misc/ACKS. Thanks Brad! Note: I adapted the change for Python 2.7: the default encoding is ASCII, not UTF-8. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
Roundup Robot added the comment: New changeset 0d38044c0b02 by Victor Stinner in branch 'default': Issue #21488: Add support of keyword arguments for codecs.encode and codecs.decode http://hg.python.org/cpython/rev/0d38044c0b02 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
STINNER Victor added the comment: Ooops, I applied codecs_decode_encode_kw.patch to the branch 3.4 instead of default :-/ I should now be fixed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
Changes by Berker Peksag berker.pek...@gmail.com: -- stage: commit review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
Roundup Robot added the comment: New changeset 0a6f0aaeb96a by Victor Stinner in branch '2.7': Issue #21488: Oops, the patch for codecs.encode/decode doc was written by http://hg.python.org/cpython/rev/0a6f0aaeb96a New changeset 91dca6b9ef0f by Victor Stinner in branch '3.4': Issue #21488: Oops, the patch for codecs.encode/decode doc was written by http://hg.python.org/cpython/rev/91dca6b9ef0f -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
Changes by Berker Peksag berker.pek...@gmail.com: -- keywords: +patch nosy: +berker.peksag, ncoghlan stage: - patch review type: resource usage - behavior versions: +Python 3.4, Python 3.5 Added file: http://bugs.python.org/file35240/issue21488.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
Brett Cannon added the comment: Berker's patch LGTM, so assigning to him to commit. -- assignee: docs@python - berker.peksag nosy: +brett.cannon stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21488] codecs.encode/decode documentation inconsistency
New submission from Brad Aylsworth: The documentation page for codecs (https://docs.python.org/2/library/codecs.html) shows keyword arguments for codecs.encode and codecs.decode, but they throw an error if keyword arguments are used. codecs.decode.__doc__ reports 'decode(obj, [encoding[,errors]]) - object. This happens on both 2.7.6 and 3.4.0. -- assignee: docs@python components: Documentation messages: 218380 nosy: Ouaouaron, docs@python priority: normal severity: normal status: open title: codecs.encode/decode documentation inconsistency type: resource usage versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21488 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
