[issue21582] use support.captured_stdx context managers - test_asyncore

2014-06-27 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset c2dba8ee4e96 by Victor Stinner in branch '3.4':
Closes #21582: Cleanup test_asyncore. Patch written by diana.
http://hg.python.org/cpython/rev/c2dba8ee4e96

New changeset f1cd0aa1561a by Victor Stinner in branch 'default':
(Merge 3.4) Closes #21582: Cleanup test_asyncore. Patch written by diana.
http://hg.python.org/cpython/rev/f1cd0aa1561a

--
nosy: +python-dev
resolution:  - fixed
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21582
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21582] use support.captured_stdx context managers - test_asyncore

2014-06-27 Thread STINNER Victor 

STINNER Victor added the comment:

The patch is simple, safe, and makes the test code cleaner. I commited your 
patch diana, thanks.

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21582
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21582] use support.captured_stdx context managers - test_asyncore

2014-05-31 Thread Ezio Melotti 

Ezio Melotti added the comment:

The patch includes two sets of changes:
1) uses support.captured_stderr() where appropriate;
2) removes some from import and uses support.x instead;

The former looks OK to me and could be applied, the latter doesn't look very 
useful.

--
nosy: +ezio.melotti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21582
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21582] use support.captured_stdx context managers - test_asyncore

2014-05-31 Thread diana 

diana added the comment:

I removed some of the from imports and used support.x instead for 
consistency. support was already being imported, and many of the things 
imported from support were already using support.x. I just made them all the 
same.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21582
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21582] use support.captured_stdx context managers - test_asyncore

2014-05-30 Thread Terry J. Reedy 

Terry J. Reedy added the comment:

Since asyncore is depracated, I don't know if tests are being updated, or if 
this should be closed.

--
nosy: +josiahcarlson, stutzbach, terry.reedy
title: use support.catpured context managers - test_asyncore - use 
support.captured_stdx context managers - test_asyncore

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21582
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com