[issue21755] test_importlib.test_locks fails --without-threads

[R. David Murray]

R. David Murray added the comment:

What is the reason for using the conditional approach rather than a skip 
decorator?  Does it not work in this context, or is it just that you copied the 
existing approach?  It's fine either way, but I'm curious.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21755] test_importlib.test_locks fails --without-threads

[Berker Peksag]

Berker Peksag added the comment:

 Does it not work in this context

Yes, it doesn't work after 34d65746d5ca because LOCK_TYPES is an empty dict 
(test_util.test_both() can't find the 'Frozen' and 'Source' keys in it) when 
Python is built without threads.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21755] test_importlib.test_locks fails --without-threads

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
assignee:  - berker.peksag
versions:  -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21755] test_importlib.test_locks fails --without-threads

[Roundup Robot]

Roundup Robot added the comment:

New changeset b88525a8c01d by Berker Peksag in branch 'default':
Issue #21755: Skip {Frozen,Source}_DeadlockAvoidanceTests tests when
http://hg.python.org/cpython/rev/b88525a8c01d

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21755] test_importlib.test_locks fails --without-threads

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
resolution:  - fixed
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21755] test_importlib.test_locks fails --without-threads

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21755] test_importlib.test_locks fails --without-threads

[Berker Peksag]

Berker Peksag added the comment:

See also 
http://buildbot.python.org/all/builders/AMD64%20Fedora%20without%20threads%203.x/builds/6779/steps/test/logs/stdio

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21755] test_importlib.test_locks fails --without-threads

[Berker Peksag]

New submission from Berker Peksag:

==
ERROR: test.test_importlib.test_locks (unittest.loader.ModuleImportFailure)
--
Traceback (most recent call last):
  File /home/berker/projects/cpython-default/Lib/unittest/case.py, line 58, 
in testPartExecutor
yield
  File /home/berker/projects/cpython-default/Lib/unittest/case.py, line 577, 
in run
testMethod()
  File /home/berker/projects/cpython-default/Lib/unittest/loader.py, line 32, 
in testFailure
raise exception
ImportError: Failed to import test module: test.test_importlib.test_locks
Traceback (most recent call last):
  File /home/berker/projects/cpython-default/Lib/unittest/loader.py, line 
312, in _find_tests
module = self._get_module_from_name(name)
  File /home/berker/projects/cpython-default/Lib/unittest/loader.py, line 
290, in _get_module_from_name
__import__(name)
  File 
/home/berker/projects/cpython-default/Lib/test/test_importlib/test_locks.py, 
line 123, in module
DeadlockError=DEADLOCK_ERRORS)
  File /home/berker/projects/cpython-default/Lib/test/test_importlib/util.py, 
line 82, in test_both
return split_frozen(test_class, base, **kwargs)
  File /home/berker/projects/cpython-default/Lib/test/test_importlib/util.py, 
line 76, in split_frozen
frozen = specialize_class(cls, 'Frozen', base, **kwargs)
  File /home/berker/projects/cpython-default/Lib/test/test_importlib/util.py, 
line 70, in specialize_class
value = values[kind]
KeyError: 'Frozen'

I've used the same logic as ModuleLockAsRLockTests to silence the test failure.

Patch attached.

--
components: Tests
files: test_locks.diff
keywords: patch
messages: 220534
nosy: berker.peksag, brett.cannon, eric.snow
priority: normal
severity: normal
stage: patch review
status: open
title: test_importlib.test_locks fails --without-threads
type: behavior
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file35625/test_locks.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com