[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[Mariatta Wijaya]

Change by Mariatta Wijaya :


--
resolution:  -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:

Thanks!

--
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[miss-islington]

miss-islington  added the comment:


New changeset 9fd5b5fdf851d35a5c1314360119850e86a1fd0d by Miss Islington (bot) 
in branch '3.6':
bpo-22069: Update TextIO documentation (GH-6609)
https://github.com/python/cpython/commit/9fd5b5fdf851d35a5c1314360119850e86a1fd0d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[Antoine Pitrou]

Change by Antoine Pitrou :


--
nosy:  -pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[miss-islington]

miss-islington  added the comment:


New changeset 84fc6c59cf286fc4e6b3a700c6db36ecc2bff92b by Miss Islington (bot) 
in branch '2.7':
bpo-22069: Update TextIO documentation (GH-6609)
https://github.com/python/cpython/commit/84fc6c59cf286fc4e6b3a700c6db36ecc2bff92b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[miss-islington]

miss-islington  added the comment:


New changeset 050e041bf7e5260013a74c75a05a3f0fb16447ec by Miss Islington (bot) 
in branch '3.7':
bpo-22069: Update TextIO documentation (GH-6609)
https://github.com/python/cpython/commit/050e041bf7e5260013a74c75a05a3f0fb16447ec


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[miss-islington]

Change by miss-islington :


--
pull_requests: +6487

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[miss-islington]

Change by miss-islington :


--
pull_requests: +6486

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[miss-islington]

Change by miss-islington :


--
pull_requests: +6485

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:


New changeset 7ffd4c58fae08b29259eebd6cbcd2287820b14e8 by Mariatta (Elena Oat) 
in branch 'master':
bpo-22069: Update TextIO documentation (GH-6609)
https://github.com/python/cpython/commit/7ffd4c58fae08b29259eebd6cbcd2287820b14e8


--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[Elena Oat]

Change by Elena Oat :


--
keywords: +patch
pull_requests: +6305
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[Elena Oat]

Elena Oat  added the comment:

Note that the correct link to the test case is:
https://github.com/python/cpython/blob/master/Lib/test/test_io.py#L2565

--
nosy: +Elena.Oat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline="\n", line_buffering=True) mistakenly treat \r as a newline

[Cheryl Sabella]

Change by Cheryl Sabella :


--
keywords: +easy
stage:  -> needs patch
versions: +Python 3.7, Python 3.8 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline=\n, line_buffering=True) mistakenly treat \r as a newline

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22069
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline=\n, line_buffering=True) mistakenly treat \r as a newline

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Looks as this behavior is intentional. Documentation should be corrected.

--
assignee:  - docs@python
components: +Documentation
nosy: +benjamin.peterson, docs@python, hynek, pitrou, stutzbach

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22069
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22069] TextIOWrapper(newline=\n, line_buffering=True) mistakenly treat \r as a newline

[Akira Li]

New submission from Akira Li:

TextIOWrapper(b, newline=\n, line_buffering=True) object calls flush() 
while writing \r. See test_line_buffering() method in 
Lib/test/test_io.py:2114

The documentation says [1]:

 If line_buffering is True, flush() is implied when a call to write contains
 a newline character.

i.e., writing \r shouldn't force flush() if newline=\n

[1] https://docs.python.org/3.4/library/io.html#io.TextIOWrapper

--
components: IO
messages: 223965
nosy: akira
priority: normal
severity: normal
status: open
title: TextIOWrapper(newline=\n, line_buffering=True) mistakenly treat \r as 
a newline
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22069
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com