[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Roundup Robot added the comment: New changeset 3b6e0720a69d by Serhiy Storchaka in branch '2.7': Issue #22095: Fixed HTTPConnection.set_tunnel with default port. The port https://hg.python.org/cpython/rev/3b6e0720a69d -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Serhiy Storchaka added the comment: Backported to 2.7 because this is needed to support proxy with a port in urllib/urllib2 as documented. See issue24311. -- versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Serhiy Storchaka added the comment: See also comments on Rietveld (e-mail notification likely fell in spam). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Demian Brecht added the comment: Thanks for the ping Serhiy, indeed the review notification email was sitting in spam. New patch addressing review comments as well as rectifying my own silliness. -- Added file: http://bugs.python.org/file37419/issue22095_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Roundup Robot added the comment: New changeset 676d6bcfc031 by Serhiy Storchaka in branch '3.4': Issue #22095: Fixed HTTPConnection.set_tunnel with default port. The port https://hg.python.org/cpython/rev/676d6bcfc031 New changeset ebe2072e5472 by Serhiy Storchaka in branch 'default': Issue #22095: Fixed HTTPConnection.set_tunnel with default port. The port https://hg.python.org/cpython/rev/ebe2072e5472 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Serhiy Storchaka added the comment: Thank you for your contribution Demian. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Changes by Demian Brecht demianbre...@gmail.com: Added file: http://bugs.python.org/file37309/issue22095_1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Demian Brecht added the comment: Thanks Serhiy, new patch addresses your comments. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Serhiy Storchaka added the comment: If call _get_hostport() in set_tunnel() then it should be removed in _tunnel(). As for tests, it would be better do not rely on implementation details. Instead you can monkey-patch the send() method of of HTTPConnection instance and check passed argument. -- nosy: +nikratio, orsenthil, serhiy.storchaka stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Demian Brecht added the comment: Bump for review -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
New submission from Demian Brecht: Creating this bug for clarity, but was encountered while investigating 22041 (now set as not a bug). When using set_tunnel with default port, the port value in the host header is set to None: send: b'POST [PATH] HTTP/1.1\r\nHost: [HOST]:None\r\nAccept-Encoding: identity\r\nContent-Length: 41\r\nAccept: text/plain\r\nContent-type: application/x-www-form-urlencoded\r\n\r\n[FORM_DATA]' This issue seems to have been introduced in 3.4 when _tunnel_host and _tunnel_port were introduced to decouple the destination host and port from the proxy host and port. -- components: Library (Lib) messages: 224175 nosy: demian.brecht priority: normal severity: normal status: open title: Use of set_tunnel with default port results in incorrect post value in host header type: behavior versions: Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22095] Use of set_tunnel with default port results in incorrect post value in host header
Changes by Demian Brecht demianbre...@gmail.com: -- keywords: +patch Added file: http://bugs.python.org/file36140/issue22095.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22095 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
