[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Chun-Yu Tseng]

Change by Chun-Yu Tseng :


--
pull_requests: +13175
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Chun-Yu Tseng]

Chun-Yu Tseng  added the comment:

My bad, I totally forget this patch. Need to spend some time to retest my code 
and catch up with current development flow. Thanks for reminding.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[daniel hahler]

daniel hahler  added the comment:

Would be nice to have this indeed.
Please consider creating a PR with an updated patch then for easier review.

--
nosy: +blueyed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Xavier de Gaye]

Xavier de Gaye added the comment:

The code review of your first patch still applies to your last patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Chun-Yu Tseng]

Chun-Yu Tseng added the comment:

Ping :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Chun-Yu Tseng]

Chun-Yu Tseng added the comment:

Appreciate for your quick response. I have already left the reply in Rietveld.

I have uploaded a new patch with revised tests. In fact, the tests I wrote in 
the first patch are based on the style of `test_pdb2.py` in #7245 . But I am 
sure that now the new tests are better than the old because they run faster and 
source code looks simpler. (Note that these tests are still skipped to run on 
Windows)

Please tell me what can I do next :)

--
Added file: http://bugs.python.org/file45928/fix-cc-and-add-tests-v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Xavier de Gaye]

Xavier de Gaye added the comment:

Thanks for the patch. See my comments in Rietveld.
I think we can skip the 'step' command.
For the tests, can you use the existing run_pdb() method and trigger the 
signals from within the code being executed with 'os.kill(os.getpid(), 
signal.SIGINT |  signal.CTRL_C_EVENT)', this would avoid having to sleep on 
delays.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Chun-Yu Tseng]

Chun-Yu Tseng added the comment:

Here comes the patch:

1. Let Pdb can also resume from `return`, `until` and `next` commands when 
receiving Control-C.

2. Explicitly raise `bdb.BdbQuit` when an unexpected exception occurs in 
`sigint_handler`. See #24283.

3. Add two tests `test_break_during_interactive_input`, 
`test_resume_from_sigint` and some helper functions to `test_pdb.py` to make 
sure that Pdb behaves as we expected.
See below, Pdb resumes back in a wrong position when receiving Control-C.  The 
environment is Python 3.5.2 (Mac).  But Pdb works right in latest 
3.5/3.6/default now. So we should have tests here.
(Pdb) list
  1  import time
  2  def f():
  3  import pdb; pdb.Pdb().set_trace();
  4  ->delay()
  5  print("* f() done *")
  6
  7  def delay():
  8  time.sleep(3)
  (Pdb) c
^C
Program interrupted. (Use 'cont' to resume).
--Call--
> /usr/local/var/pyenv/versions/3.5.2/lib/python3.5/signal.py(45)signal()
-> @_wraps(_signal.signal)
(Pdb)



What this patch does NOT do are:

1. Let Pdb can resume from `step` command.
I tried by the same way like what I did for `continue/return/until/next` 
commands, but Pdb resumed back at the beginning of `sigint_handler`. The user 
should type in `continue` to go to the right place. I can't find an elegant way 
to work around it:
-> time.sleep(3)
(Pdb) s
^C--Call--
> /Users/chun-yutseng/Projects/cpython/Lib/pdb.py(189)sigint_handler()
-> def sigint_handler(self, signum, frame):
(Pdb) l
184  self.commands_defining = False # True while in the process of 
defining
185 # a command list
186  self.commands_bnum = None # The breakpoint number for which we 
are
187# defining a list
188
189  ->def sigint_handler(self, signum, frame):
190  if self.allow_kbdint:
191  raise KeyboardInterrupt
192  try:
193  self.message("\nProgram interrupted.")
194
(Pdb)

2. Let the two added tests can be run on Windows.
I tried, but when I found that I may need to use Windows-specific signals 
(CTRL_C_EVENT/CTRL_BREAK_EVENT) in `pdb.py` to let automated tests pass, I 
decided not to introduce such complexity.
So I use `@unittest.skipIf` to skip these two tests and tested the patch on 
Windows manually.


Call for review/advice/guides, please.

--
keywords: +patch
nosy: +Chun-Yu Tseng
versions: +Python 3.7 -Python 3.5
Added file: http://bugs.python.org/file45913/fix-cc-and-add-tests.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Xavier de Gaye]

New submission from Xavier de Gaye:

Pdb sets a handler for the SIGINT signal (which is sent when the user presses 
Ctrl-C on the console) when you give a continue command.
'continue' is not the only pdb command that may be interrupted, all the 
commands that resume the execution of the program (i.e. the 'do_xxx' Pdb 
methods that return 1), except for the ones that terminate pdb, should also set 
the SIGINT signal handler. These are the 'step', 'next', 'until' and 'return' 
commands.
For example, a 'next' command issued at the invocation of a function when the 
function is doing a long processing and the user wishes to break into pdb again 
with Ctrl-C within this function.

It is probably better to fix this issue after issue 20766 is fixed.

--
components: Library (Lib)
messages: 224772
nosy: xdegaye
priority: normal
severity: normal
status: open
title: allow to break into pdb with Ctrl-C for all the commands that resume 
execution
type: behavior
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22135
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22135] allow to break into pdb with Ctrl-C for all the commands that resume execution

[Xavier de Gaye]

Changes by Xavier de Gaye xdeg...@gmail.com:


--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22135
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com