[issue22137] Test imaplib API on all methods specified in RFC 3501

[Maciej Szulik]

Maciej Szulik added the comment:

Per the discussion we've had with David on IRC here's what happening. The last 
patch I've submitted is meant to clean up the tests by:
1. having single _setup method 
2. the _setup method should addClenup to clean the environment
3. have stubs with implemented mostly used methods, all others should be 
implemented ad-hoc in test methods
4. use unittest.main() for running tests

The current idea is to create tests along the current one, to show how the new 
improve the readability. For this work I'm reopening previously submitted issue 
http://bugs.python.org/issue25591 

The current issue will be on dependent on it and no further work should be done 
unless we have the tests cleared.

--
keywords:  -patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[R. David Murray]

R. David Murray added the comment:

I'm afraid I don't remember the details of our conversations at PyCon.  
Specifically, I don't remember what problem(s) it is you are trying to solve 
with this patch.

What is the reason for not just adding your new tests to the 
ThreadedNetworkTests test case?  That way they would be run both in regular 
mode and SSL mode.  You seem to have copied bits of the code from that test 
into yours, but it mostly moves the code away from our usual conventions.  That 
is, we generally put the support classes at the top level and then subclass 
them in test methods that need variations, rather than defining them in setup 
methods (where they would inaccessible unless assigned to self).  Also, the 
existing reap_server method is to be preferred over a chain of addCleanups.  
Finally, we are moving all tests to using unittest.main() so that they can be 
called using unittest only instead of requiring regrtest, so the change in the 
__main__ block is incorrect.

Now, all that said, I can see several things I'd do to refactor the existing 
tests to make them clearer and easier to modify.  For example, there are better 
ways to get reap_threads called on all test methods than wrapping each one 
individually (ex: tearDownClass).  And I prefer setup methods that do 
addCleanup (in this case, addCleanup(self.reap_server), rather than the 
existing context manager approach, though I don't know how widespread my 
preferred pattern is in our test suite yet.

All of which has little to do with the title of this issue :).  So, perhaps we 
should open a new issue for refactoring the tests, and then come back to this 
one once we are both satisfied with the refactoring?  We can cite this issue as 
the motivation for the refactoring.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Maciej Szulik]

Maciej Szulik added the comment:

Resubmitting from http://bugs.python.org/issue25591, which I filled in 
unnecessarily. 

Here are the rewritten test case I've developed during PyCon sprints along with 
David. Once we'll have the entire test suite in place it'll be safer to 
introduce any changes I'd like to cover, including updating the implementation 
to newest RFC 3501 version.

--
hgrepos: +325
Added file: http://bugs.python.org/file41264/new_imap_tests.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Maciej Szulik]

Maciej Szulik added the comment:

Thanks Milan for the info, I was about to ping you about that. I have a working 
prototype for the tests that I've been working on during PyCon sprints with 
David. I'll try to submit new patch within a couple of next days.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Milan Oberkirch]

Milan Oberkirch added the comment:

Thanks a lot for reviewing my patch! I'm currently travalling so I'm totally 
fine with you taking over this issue (would take me a few weeks till I can 
work on it).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Maciej Szulik]

Maciej Szulik added the comment:

Milan one more thing to change in your patch, in all your TCs you're modifying 
client state, I mean this part:

# lets cheat a bit here:
client.state = 'SELECTED'

It's OK to do that on the mocked server, but this is not acceptable doing on 
the tested library. It's better to call client.login() to change the state to 
'AUTH' properly and only after that, call the actual method under test.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Maciej Szulik]

Maciej Szulik added the comment:

Milan, thanks for your patch, I've added comments to it (look for review link 
next to submitted file), can you address them please? 
Other option is, if you don't mind, I'll take over this issue and finish on top 
of your work.

--
nosy: +maciej.szulik

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Maciej Szulik]

Maciej Szulik added the comment:

One more thing I didn't mention before is, please update it to match current 
default, as it's failing patching, right now.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Antoine Pitrou]

Antoine Pitrou added the comment:

Perhaps you need to close the client connection explicitly? (i.e. shutdown())

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Milan Oberkirch]

Milan Oberkirch added the comment:

Okay that was stupid from me (it was 5am when I submitted it), sorry.

--
Added file: http://bugs.python.org/file36271/imaplib_test_rfc3501v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22137] Test imaplib API on all methods specified in RFC 3501

[Milan Oberkirch]

New submission from Milan Oberkirch:

I finished writing tests for all methods which are specified in RFC 3501 but 
left out extensions for now. The attached patch will trigger many resource 
warnings. Do you have an idea why the sockets aren't closed?

--
files: imaplib_test_rfc3501.patch
keywords: patch
messages: 224790
nosy: jesstess, pitrou, r.david.murray, zvyn
priority: normal
severity: normal
status: open
title: Test imaplib API on all methods specified in RFC 3501
Added file: http://bugs.python.org/file36263/imaplib_test_rfc3501.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22137
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com