[issue22191] warnings.__all__ incomplete
Jon Poler added the comment: Thanks, Brett! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Brett Cannon added the comment: And Python 2.7. -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Brett Cannon added the comment: The patch looks good, Jon! I'm running the test suite now to make sure nothing odd happens from the change, but barring that this should be committed in Python 3.4 and default shortly. -- stage: - commit review status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Roundup Robot added the comment: New changeset a77dc87a34ff by Brett Cannon in branch '3.4': Issue #22191: Fix warnings.__all__. http://hg.python.org/cpython/rev/a77dc87a34ff New changeset aeb5fc7a9956 by Brett Cannon in branch 'default': Merge for issue #22191 fix http://hg.python.org/cpython/rev/aeb5fc7a9956 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Roundup Robot added the comment: New changeset 727fd4ead3fd by Brett Cannon in branch '2.7': Issue #22191: Fix warnings.__all__. http://hg.python.org/cpython/rev/727fd4ead3fd -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Changes by Brett Cannon br...@python.org: -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Changes by Brett Cannon br...@python.org: -- assignee: - brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Jon Poler added the comment: Here is a patch that changes __all__ in Lib/warnings.py to include the functions mentioned in the library reference https://docs.python.org/dev/library/warnings.html#available-functions. A unittest is included. This is my first patch, so comments/feedback are welcome (from now on, I should probably add). -- keywords: +patch Added file: http://bugs.python.org/file36383/warnings.__all__.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Serhiy Storchaka added the comment: See also issue20689. socket.__all__ is incomplete too. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Jon Poler added the comment: Serhiy, should I submit these fixes as separate patches? E.g. one patch for the warnings module, and another for the socket module? More generally, should the items included in __all__ be derived from the items described in the documentation? For instance, only the functions listed in 18.1.2 https://docs.python.org/dev/library/socket.html#module-contents ? And finally, should a unittest be added for both of these modules to ensure that __all__ includes all of the desired publicly exposed elements? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Brett Cannon added the comment: Yes, please use separate patches attached to the appropriate bug. As for what should go into __all__, it's what is documented as the API of the module. As for tests, it doesn't hurt. =) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
New submission from Antoine Pitrou: If you try `pydoc warnings` (or `help(warnings)` in the interpreter prompt) you'll notice that some functions such as simplefilter() don't appear. This seems to be because warnings.__all__ is incomplete. -- components: Library (Lib) keywords: easy messages: 225279 nosy: brett.cannon, ncoghlan, pitrou priority: normal severity: normal status: open title: warnings.__all__ incomplete type: behavior versions: Python 2.7, Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Jon Poler added the comment: Antoine: I'll look in to this unless you want do so yourself. Thanks. -- nosy: +jon.poler ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22191] warnings.__all__ incomplete
Antoine Pitrou added the comment: Jon, please do! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22191 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
