[issue22227] Simplify tarfile iterator

[Roundup Robot]

Roundup Robot added the comment:

New changeset a8f24e26abc7 by Serhiy Storchaka in branch 'default':
Issue #7: The TarFile iterator is reimplemented using generator.
https://hg.python.org/cpython/rev/a8f24e26abc7

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thanks Martin and Raymond for reviews.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Updated patch addresses Martin's comments. Thanks Martin.

--
versions: +Python 3.6 -Python 3.5
Added file: http://bugs.python.org/file40101/tarfile_tariter_2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Robert Collins]

Changes by Robert Collins robe...@robertcollins.net:


--
stage: patch review - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Raymond Hettinger]

Raymond Hettinger added the comment:

The patch looks good and passes tests.  Go ahead and apply.

--
assignee: lars.gustaebel - serhiy.storchaka
nosy: +rhettinger

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Robert Collins]

Robert Collins added the comment:

@serhiy could you update the patch with the review feedback? Thanks. Moving 
back to patch review. Lars hasn't commented on this in a year, so I think we 
should go ahead once the patch is fixed: e.g. you should update the comments 
and commit it directly.

--
nosy: +rbcollins
stage: commit review - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

The patch doesn't fix a bug and doesn't add new feature. It just rewrites the 
code in more clear manner (in my eyes). So I leave applying or rejecting the 
patch on Lars.

--
assignee:  - lars.gustaebel

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Mark Lawrence]

Mark Lawrence added the comment:

LGTM at a quick glance.  Can we have a formal patch review please.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Martin Panter]

Changes by Martin Panter vadmium...@gmail.com:


--
nosy: +vadmium

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Martin Panter]

Martin Panter added the comment:

The code changes look correct and worthwhile to me. Just added some suggestions 
for the comments, which would become out of date.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
stage: patch review - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22227] Simplify tarfile iterator

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

TarFile iteration can be simplified by using a generator instead of iterator 
class. Attached patch get rid of the TarIter class and decrease sources size by 
16 lines.

--
components: Library (Lib)
files: tarfile_tariter.diff
keywords: patch
messages: 225521
nosy: lars.gustaebel, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Simplify tarfile iterator
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file36412/tarfile_tariter.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com