[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: Fixed by r65834, thanks to the patch provided in issue3496. Will backport. -- nosy: +amaury.forgeotdarc resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: committed r65835 in the release25-maint branch. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Jose Antonio Martin H [EMAIL PROTECTED] added the comment: I have the same problem, i have patched the file and now it works ok. -- nosy: +jamartinh ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Jason Tishler [EMAIL PROTECTED] added the comment: cygwinccompiler.py only uses the first group: $ fgrep group cygwinccompiler.py gcc_version = StrictVersion(result.group(1)) ld_version = StrictVersion(result.group(1)) dllwrap_version = StrictVersion(result.group(1)) So, I would like to move forward with the regular expression from http://cygwin.com/ml/cygwin/2008-05/msg00622.html: (\d+\.\d+(\.(\d+))?([ab](\d+))?) Can we get a consensus? ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Jason Tishler [EMAIL PROTECTED] added the comment: I tested the regular expression in #3: (\d+\.\d+(\.(\d+))?([ab](\d+))?) and it worked for both '2.18.50.20080523' '1.2.3a'. Additionally, it worked for the following test cases that I tried: 2.18.50a.20080523 2.18.50a 20080523 2.18.50 20080523 1.2.3 Unfortunately, I don't know what is the set of all possible version formats that ld -v can return. So, I don't know how to devise a regular expression guaranteed to work for all ld versions including future ones. AFAICT, we have only two options to resolve this issue: 1. Improve the regular expression as best we can and continue to change it as necessary in the future. 2. Remove the fragile version checking all together and make an explicit decision to only support modern binutils. Any opinions? ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Will Brown [EMAIL PROTECTED] added the comment:
Maybe I have a problem with my test code...
import re
def test_re(out_string):
result = re.search('(\d+\.\d+(\.(\d+))?([ab](\d+))?)', out_string)
print '--- msg00622 ---'
print result.group(1)
print result.group(2)
print result.group(3)
print result.group(4)
print
if __name__ == '__main__':
out_string = '2.18.50.20080523'
test_re(out_string)
out_string = '1.2.3a'
test_re(out_string)
out_string = '2.18.50a.20080523'
test_re(out_string)
Results...
--- msg00622 ---
2.18.50
.50
50
None
--- msg00622 ---
1.2.3
.3
3
None
--- msg00622 ---
2.18.50
.50
50
None
I would expect GNU to have a standard for version strings so this
doesn't happen to EVERYONE when they deviate from the expected.
A quick check in Google returned the following links for other
packages...
http://publib.boulder.ibm.com/tividd/td/ITCM/SC23-4712-01/en_US/HTML/cmm
st19.htm
http://java.sun.com/j2se/versioning_naming.html
http://www.osgi.org/javadoc/r4/org/osgi/framework/Version.html
Given that, I think I prefer 1 to 2.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2234
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Jason Tishler [EMAIL PROTECTED] added the comment: There have been three different regular expressions proposed to resolve this issue: 1. http://bugs.python.org/issue2234 2. http://bugs.python.org/issue3013 3. http://cygwin.com/ml/cygwin/2008-05/msg00622.html Does anyone know which one is best? I would like to release a patched Cygwin Python 2.5.2 that resolves this issue, but I feel we should reach consensus on what regular expression to use before I do so. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Will Brown [EMAIL PROTECTED] added the comment: None of the above will work on both '2.18.50.20080523' '1.2.3a' -- William Brown -- -- Boeing Networked Systems Technology -- Kent:253.657.5586 Blvu:425.373.2738 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Will Brown [EMAIL PROTECTED] added the comment: Same problem in version.py, line 100 (StrictVersion) -- nosy: +wmbrown ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Benjamin Peterson [EMAIL PROTECTED] added the comment: This seems to be the same as #3013. -- nosy: +benjamin.peterson ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Will Brown [EMAIL PROTECTED] added the comment: Yes, same problem. Multiple files. I should have read the discussion more carefully. My note was redundant. Will -- William Brown -- -- Boeing Networked Systems Technology -- Kent:253.657.5586 Blvu:425.373.2738 -Original Message- From: Benjamin Peterson [mailto:[EMAIL PROTECTED] Sent: Tuesday, June 10, 2008 2:25 PM To: Brown, William J Subject: [issue2234] cygwinccompiler.py fails for latest MinGW releases. Benjamin Peterson [EMAIL PROTECTED] added the comment: This seems to be the same as #3013. -- nosy: +benjamin.peterson ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Jason Tishler [EMAIL PROTECTED] added the comment: If the version is guaranteed to be x.y or x.y.z, then the patch seems correct. Note I am not set up to test this patch and it has been years since I have looked at this part of the code base. Sorry, that I can't be more helpful. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Lenard Lindstrom [EMAIL PROTECTED] added the comment: distutils.version.StrictVersion.parse does not handle x.y.z.n . That is why there is an exception. I have tested the patch both with binutils-2.18.50-20080109 (*), the latest version (a Technology Preview), and its predecessor binutils-2.18.50-20071123, which also works without the proposed patch. I use MinGW to build Pygame. Finally, there should be no reason to use earlier versions of binutils with Python 2.4 and up as msvcr71 support was introduced only a couple of years ago. (*) The MinGW binutils bundle contains both ld and dllwrap __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2234] cygwinccompiler.py fails for latest MinGW releases.
Sean Reifschneider [EMAIL PROTECTED] added the comment: This patch looks ok to me, but I'd like jlt63 to review it since they were the last to touch these regexes. -- assignee: - jlt63 keywords: +easy nosy: +jafo, jlt63 priority: - normal type: - behavior __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2234 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
