[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Éric Araujo]

Change by Éric Araujo :


--
versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.5, Python 
3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Senthil Kumaran]

Change by Senthil Kumaran :


--
assignee:  -> orsenthil
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Michael Handler]

Change by Michael Handler :


--
pull_requests: +7839

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag
versions: +Python 3.7 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +655

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Vova]

Vova added the comment:

I don't know why I hardcoded version of HTTP, it was almost 6 months ago. Maybe 
because it just POC, or maybe because HTTP 1.0 is not allowed CONNECT method. 
Thank you for your patch and also for IDN support.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22708
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Martin Panter]

Martin Panter added the comment:

Patch looks good to me. I’m not an expert on non-ASCII domain names, but 
enabling HTTP 1.1 should be okay, at least for new versions of Python. CONNECT 
for HTTP 1.1 is described at 
https://tools.ietf.org/html/rfc7231#section-4.3.6.

Also, see the code review about removing an comment about HTTP 1.1 blessing.

--
nosy: +vadmium

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22708
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Demian Brecht]

Demian Brecht added the comment:

Thanks for the report and follow up Vova. I've come across this line and it 
puzzled me as well as to why it's hardcoded. Rather than the hardcoded approach 
in your patch, I've attached a patch that uses _http_vsn_str which is 
consistent with other areas of the library.

Additionally, I noticed that a failure will occur if the destination address 
contains characters outside of ASCII range, so I've added support for IDN.

I assume that the patch should be committed to tip and maintenance branches as 
both issues are bugs (there is IDN support elsewhere in the library).

--
nosy: +demian.brecht
stage: resolved - patch review
versions:  -Python 3.2, Python 3.3
Added file: http://bugs.python.org/file38808/issue22708.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22708
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Vova]

New submission from Vova:

At my workplace I have to use corporate Internet proxy server with 
AD/domain/ntlm authorization. I use local cntlm proxy server to authorize 
myself on corporate proxy. Programs are send requests to cntlm proxy without 
any authorization information. Cntlm proxy communicate with corporate proxy and 
handle all authorization stuff and return response to programs. 

But programs which use httplib, like pip, and want to open https url can't work 
in my network scheme. Because to open https connection httplib send to cntlm 
proxy 

CONNECT encrypted.google.com:443 HTTP/1.0\r\n

HTTP/1.0 does not assume persistent connection so corporate proxy return http 
response 407 (need authorization) and close connection. Cntlm proxy detect 
closed connection and return http response 407 to pip/httplib which can't 
handle this response or begin ntlm negotiation, throw exception 

ProxyError('Cannot connect to proxy.', error('Tunnel connection failed: 407 
Proxy Authentication Required',))  

and close.

So I suggest change HTTP CONNECT method to 

CONNECT %s:%d HTTP/1.1\r\n

This change allow cntlm proxy keep alive connection to corporate proxy do all 
authorization stuff and return proper response. 

And also in header of httplib is stated what it is HTTP/1.1 client library

--
components: Library (Lib)
files: py2.7.httplib.patch
keywords: patch
messages: 229856
nosy: vova
priority: normal
severity: normal
status: open
title: httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file36996/py2.7.httplib.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22708
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[R. David Murray]

R. David Murray added the comment:

See issue 21224 and issue 9740.  It's not 100% clear to me from reading those 
issues, but it *sounds* like the support is there, you just have to turn it on. 
 So I'm closing this issue as not a bug...either it already works (and you just 
have to set your code to use 1.1) or this is a duplicate of one of those two 
issues, and you should comment on whichever one is more appropriate.

Your point about PIP is a good one, though...that might be worth a specific 
issue for 1.1 support in pip, if it doesn't already have a way to switch it on.

--
nosy: +r.david.murray
resolution:  - not a bug
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22708
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22708] httplib/http.client in method _tunnel used HTTP/1.0 CONNECT method

[Vova]

Vova added the comment:

The issue http://bugs.python.org/issue21224 is about http server 
implementations. The issue http://bugs.python.org/issue9740 is more relevant 
for what I talking about, but not exactly.

Look, in this line 

https://hg.python.org/cpython/file/6a2f74811240/Lib/http/client.py#l786

http protocol version is setted and in this line 

https://hg.python.org/cpython/file/6a2f74811240/Lib/http/client.py#l1036

variable used to send http method (GET, PUT etc) and it work for direct 
connection or proxy with http connections. But if required to use CONNECT 
method through proxy (usually used for https connection) will be used _tunnel() 
method from http.client (py3k) or httplib (py2.7)

https://hg.python.org/cpython/file/6a2f74811240/Lib/http/client.py#l871

and here version off http is hardcoded to HTTP/1.0

PIP use urllib3, but urllib3 for actual network working (work with socket and 
send request) use httplib or http.client. So I think it would be better to make 
changes in httplib than override _tunnel() method in urllib3.

P.S. I'm not sure about rules how to open/close issues, so I open this issue 
again. I'm sorry if this causes some inconvenience.

--
resolution: not a bug - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22708
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com