[issue23085] update internal libffi copy to 3.2.1

[Zachary Ware]

Zachary Ware added the comment:

I'm closing this as superseded by #27976, which deprecates building with the 
bundled libffi.

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed
superseder:  -> Deprecate building with bundled copy of libffi on non-Darwin 
POSIX platforms

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Ned Deily]

Ned Deily added the comment:

We should be able to make things work for OS X installer builds one way or 
another so don't let that be a factor.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Zachary Ware]

Changes by Zachary Ware :


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Zachary Ware]

Zachary Ware added the comment:

OSX and Windows are both exempt from this discussion.  Each has its own private 
copy of an ancient version of libffi: Modules/_ctypes/libffi_osx/ and 
Modules/_ctypes/libffy_msvc/.

I would be in favor of switching to --with-system-ffi by default for 3.6 and 
deprecating building with the bundled full copy of libffi 
(Modules/_ctypes/libffi/), to be removed in 3.7.  OSX would also default to 
--with-system-ffi, but would still fall back to its private copy when a system 
copy isn't available.

It seems like most Linux and BSD distributions would be better off with 
system-ffi.  I'm not sure how cross-builds would have to deal with things in 
3.7, but they already have to deal with dependencies like openssl, bz2, and 
lzma; adding libffi to that mix shouldn't be that big of a deal.

Adding Ned to confirm that building OSX installers wouldn't be affected as long 
as we don't touch Modules/_ctypes/libffi_osx/ and there's not a system copy of 
libffi available.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[R. David Murray]

R. David Murray added the comment:

See msg243261, I think.  On linux and freebsd we could theoretically leave that 
to the distros, but on OSX we have to deal with it ourselves.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[koobs]

koobs added the comment:

Forgive me for asking a question that may have already been asked, or beaten to 
death, but what is preventing Python from requiring libffi as an 
external/required dependency, rather than keeping it and taking on the burden 
of fixes/backporting in lieu of updates or pending releases from upstream?

Historically (at least the last ~2-3 years), libffi in Python has been plagued 
with, at least:

* Inconsistent / incorrect merging of libffi fixes (including regressions)
* Unsolved issues in vendored copy that have been fixed/released upstream
* Complex, manual and error-prone updates to vendored copy
* Lack of regular maintenance, from what largely appears to be a lack of 
knowledge about, or confidence in updating the vendored copy (fear of breakage)

I know at least FreeBSD currently requires --sytem-libffi for i386 systems in 
certain versions due to issue 22521 (issue 23042) and there are currently 50 
open issues matching libffi (granted not all of them will be root-caused by 
libffi internal). I note that number to highlight the maintenance requirement.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Xavier de Gaye]

Xavier de Gaye added the comment:

> Cross-compile CPython for ARM with clang fails in _ctypes due to 
> https://llvm.org/bugs/show_bug.cgi?id=20595. This bug is already fixed in 
> libffi.

I have entered issue 27627 for this problem.

--
nosy: +xdegaye

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

Oops the proglem of clang on ARM is not completely fixed in libffi 3.2.1. This 
commit [1] fixes only one `stmeqia` but not another.

[1] 
https://github.com/libffi/libffi/commit/6eff9ff9e72463b9783be2514f944b6f05692054#diff-c6400d42bf23866ded49558ca9a54205R220

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Zachary Ware]

Changes by Zachary Ware :


--
versions: +Python 3.6 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

+1 for this. Cross-compile CPython for ARM with clang fails in _ctypes due to 
https://llvm.org/bugs/show_bug.cgi?id=20595. This bug is already fixed in 
libffi.

By the way, I can't apply libffi.patch to the default branch. Some hunks are 
rejcted. Is there something wrong?

issue26942 may also be relevant. I did't test it as I'm not sure how to update 
CPython's internal libffi.

--
nosy: +Chi Hsuan Yen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Berker Peksag]

Berker Peksag added the comment:

> which Berker says have been fixed in upstream libffi: 
> https://bugs.python.org/issue25077#msg266068

Correct, here is the actual commit: 
https://github.com/libffi/libffi/commit/4a677a425c18eda4bc5357b2485da57f133f908d

I have also sent a patch to upstream libffi for 
https://github.com/python/cpython/blob/master/Modules/_ctypes/libffi.diff#L161: 
https://github.com/libffi/libffi/commit/1e82e1cda43dacd8b6ab2d9ac4db33523d86f5dc

But both of them will be released in libffi 4.0.

Note that the current master branch of libffi doesn't seem to be compiled with 
a C89 compiler (see https://github.com/libffi/libffi/issues/218 for details). 
See also https://mail.python.org/pipermail/python-dev/2016-June/144816.html for 
discussion about C99 support in CPython.

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Chris Jerdonek]

Chris Jerdonek added the comment:

> Are there any issue *we* have with libffi which an update to 3.2.1 would 
> solve ?

There are these Ubuntu-specific compiler warnings:
https://bugs.python.org/issue25077

which Berker says have been fixed in upstream libffi: 
https://bugs.python.org/issue25077#msg266068

--
nosy: +chris.jerdonek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

issue23042 is fixed now. libffi 3.2.1 apparently has the same issue, so the 
issue23042 patch would probably have to be reapplied (slightly modified, 
though).

Seeing that libffi has had a major compilation problem breaking it on at least 
FreeBSD and most probably a lot of other x86 based systems as well, I don't 
really have much confidence in the libffi maintenance, so the usual latest is 
the greatest may not be the best approach.

Are there any issue *we* have with libffi which an update to 3.2.1 would solve ?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Fabio Perez]

Fabio Perez added the comment:

Ping

--
nosy: +fabiovmp

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[koobs]

Changes by koobs koobs.free...@gmail.com:


--
nosy: +koobs

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Gustavo Temple]

Gustavo Temple added the comment:

@steve.dower, so, can I abandon this issue?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Steve Dower]

Steve Dower added the comment:

I'm not entirely familiar with our layout of libffi, but I don't think your 
patch will affect Windows at all. If your intent was to update the version used 
in Windows builds, then you may as well abandon it. I'm not the one to ask 
about other platforms - apparently we need new ctypes maintainers...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Gustavo Temple]

Gustavo Temple added the comment:

@steve.dower, so no problems, because my patch won't affect Windows.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Gustavo Temple]

Changes by Gustavo Temple gustavo.pedr...@eldorado.org.br:


--
title: update internal libffi copy to 3.1 - update internal libffi copy to 
3.2.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Gustavo Temple]

Gustavo Temple added the comment:

@doko, sorry, but what are the Steve's changes? The issue #22733?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Steve Dower]

Steve Dower added the comment:

I think Matthias is referring to #20160, but as far as I could tell libffi is 
multiple versions ahead of the version in Python and already has the fixes. I 
was told to wait for it to be submitted/accepted upstream, so I've been waiting 
:)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Matthias Klose]

Matthias Klose added the comment:

you should actively drive upstream integration, and ping patches if they are 
not addressed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Steve Dower]

Steve Dower added the comment:

As I mentioned on the other post, libffi's current version bears no relation to 
what we have in CPython, so the patches don't apply. I'm not planning on 
rewriting CPython patches so that they will apply to libffi, nor do I intend to 
replace our current version of it with libffi's latest. There's nothing to send 
upstream.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

Will this also fix http://bugs.python.org/issue23042 ?

--
nosy: +lemburg

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23085] update internal libffi copy to 3.2.1

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:


--
nosy: +Arfrever

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com