[issue23216] IDLE grep/find/replace source code needs docstrings

[Cheryl Sabella]

Change by Cheryl Sabella :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[miss-islington]

miss-islington  added the comment:


New changeset b34f1aa81433d60aee7bd744352b347dd650ca84 by Miss Islington (bot) 
in branch '3.7':
bpo-23216: IDLE: Add docstrings to search modules (GH-12141)
https://github.com/python/cpython/commit/b34f1aa81433d60aee7bd744352b347dd650ca84


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[miss-islington]

Change by miss-islington :


--
pull_requests: +12336
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Cheryl Sabella]

Cheryl Sabella  added the comment:


New changeset 0bb5e75cf8bc9b197ffb91cba6f30543ed502708 by Cheryl Sabella in 
branch 'master':
bpo-23216: IDLE: Add docstrings to search modules (GH-12141)
https://github.com/python/cpython/commit/0bb5e75cf8bc9b197ffb91cba6f30543ed502708


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Terry J. Reedy]

Terry J. Reedy  added the comment:

There are several minor things to fix after this (and multiple issues), 
including the difference between find in search and replace.  It seems to me 
that is should be the same.  We will definitely need to test changes on both 
Windows and Linux.

The font color issue is essentially the one that resulted in white on white in 
the completions box.  We should always set both foreground and background to 
make sure consistent.  Another nit for followup.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Cheryl Sabella]

Cheryl Sabella  added the comment:

I've created the first PR for docstrings on replace.  Saimadhav Heblikar had 
added some docstrings under issue 21676, so I expanded on what he did.  I 
referred to Al's diff, but didn't use it much since there were already some 
docstrings.

For readability, I also changed some boolean values from 0 to False and 1 to 
True.  I had to figure out what `ok` did, so that helped.

I also left a note in `show_hit` because it isn't working right.  The text gets 
colorized with the `sel` tag instead of the `hit` tag.  effbot says this about 
tag ordering:
>>> If you attach multiple tags to a range of text, style options from the most 
>>> recently created tag override options from earlier tags. In the following 
>>> example, the resulting text is blue on a yellow background.

>>>text.tag_config("n", background="yellow", foreground="red")
>>>text.tag_config("a", foreground="blue")
>>>text.insert(contents, ("n", "a"))

>>> Note that it doesn’t matter in which order you attach tags to a range; it’s 
>>> the tag creation order that counts.

The note seems to be the important part here as the definition for `sel` is 
done before `hit` in colorizer.

--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Cheryl Sabella]

Change by Cheryl Sabella :


--
pull_requests: +12142
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Cheryl Sabella]

Change by Cheryl Sabella :


--
assignee:  -> cheryl.sabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Current module names, docstring status, and note.

grep - present, some args not doc'ed
replace - spotty; do not repetively doc 'event=None' args
search - ditto
searchbase - present
searchengine - present; do not separately docstring 'isxyz' wrappers

Closing """ must be on line by itself.

Parts of the patch should be usable at least as 'first drafts' for filling in 
missing docstrings.  I am not sure whether better to edit diff (maybe after 
splitting into diffs for each module) and apply (I have never done this with 
git) or to edit modules directly.

Cheryl, another one you might want to grab.

--
nosy: +cheryl.sabella
stage: patch review -> needs patch
versions: +Python 3.7, Python 3.8 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +terry.reedy
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23216
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Al Sweigart]

New submission from Al Sweigart:

The following IDLE files need docstrings for their methods:

GrepDialog.py
SearchEngine.py
SearchDialogBase.py
SearchDialog.py
ReplaceDialog.py

--
components: IDLE
files: idle_docstrings.diff
keywords: patch
messages: 233807
nosy: Al.Sweigart
priority: normal
severity: normal
status: open
title: IDLE grep/find/replace source code needs docstrings
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file37663/idle_docstrings.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23216
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23216] IDLE grep/find/replace source code needs docstrings

[Al Sweigart]

Changes by Al Sweigart asweig...@gmail.com:


--
versions: +Python 2.7, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23216
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com