[issue23304] Unused Superclass in calendar.py
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - not a bug status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23304] Unused Superclass in calendar.py
Changes by Berker Peksag berker.pek...@gmail.com: -- stage: commit review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23304] Unused Superclass in calendar.py
Serhiy Storchaka added the comment: I suppose that calendar.error is here for compatibility. It is an alias to ValueError, so that errors raised by the calendar module can be catched with the except calendar.error: statement. Making calendar.error different class will likely break user code. I am inclined to reject this patch. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23304] Unused Superclass in calendar.py
Berker Peksag added the comment: Looks like error was unused since https://hg.python.org/cpython/rev/acdc0b9a6c78#l2.48 (see also https://hg.python.org/cpython/rev/6ee380349c84/ for time.gmtime()). LGTM. -- nosy: +berker.peksag stage: - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23304] Unused Superclass in calendar.py
Vipul Sharma added the comment: I am submitting a patch file, hope this works. Please review it and correct me if I am wrong anywhere as this is my first contribution. -- keywords: +patch nosy: +Vipul.Sharma Added file: http://bugs.python.org/file37891/calendar_1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23304] Unused Superclass in calendar.py
New submission from CliffM: calendar.py ( lines 17,18 ) is not used : # Exception raised for bad input (with string parameter for details) error = ValueError This could either be deleted OR used as the superclass in the next two class declarations as the comment suggests. -- components: Library (Lib), Tests messages: 234513 nosy: CliffM priority: normal severity: normal status: open title: Unused Superclass in calendar.py versions: Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23304] Unused Superclass in calendar.py
Changes by SilentGhost ghost@gmail.com: -- keywords: +easy versions: +Python 3.5 -Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23304 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com