[issue23310] Mock constructor configuration fails for magic methods

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8e5592a43d65 by Łukasz Langa in branch '3.4':
Issue #23310: Fix MagicMock's initializer to work with __methods__.
https://hg.python.org/cpython/rev/8e5592a43d65

New changeset dd8f48ff9480 by Łukasz Langa in branch 'default':
Merge 3.4 (#23310)
https://hg.python.org/cpython/rev/dd8f48ff9480

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23310] Mock constructor configuration fails for magic methods

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4d1236b180be by Łukasz Langa in branch 'default':
Issue #23310: Fix MagicMock's initializer to work with __methods__.
https://hg.python.org/cpython/rev/4d1236b180be

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23310] Mock constructor configuration fails for magic methods

[Łukasz Langa]

Changes by Łukasz Langa :


--
keywords: +needs review
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23310] Mock constructor configuration fails for magic methods

[Łukasz Langa]

Changes by Łukasz Langa :


--
assignee:  -> lukasz.langa
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23310] Mock constructor configuration fails for magic methods

[Kasia Jachim]

Kasia Jachim added the comment:

Added more logging to the patch.

--
Added file: http://bugs.python.org/file38922/fix_magic_in_init_v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23310] Mock constructor configuration fails for magic methods

[Kasia Jachim]

Kasia Jachim added the comment:

For Mock both the following tests fail, I would say it is an expected behavior.

def test_setting_magic_method_for_mock(self):
m = Mock()
m.configure_mock(**{'__str__.return_value': "14"})
self.assertEqual(str(m), "14")

def test_setting_magic_method_in_mock_initialization(self):
m = Mock(**{'__str__.return_value': "12"})
self.assertEqual(str(m), "12")

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23310] Mock constructor configuration fails for magic methods

[Kasia Jachim]

Kasia Jachim added the comment:

Tests for this bug + proposed fix.

--
keywords: +patch
nosy: +kjachim
Added file: http://bugs.python.org/file38919/fix_magic_in_init.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23310] Mock constructor configuration fails for magic methods

[Anand Reddy Pandikunta]

Anand Reddy Pandikunta added the comment:

mock itself fails

--
nosy: +Anand Reddy Pandikunta
title: MagicMock constructor configuration fails for magic methods -> Mock 
constructor configuration fails for magic methods
Added file: http://bugs.python.org/file38654/test_mock.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com