[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-24 Thread Brett Cannon 

Brett Cannon [EMAIL PROTECTED] added the comment:

On Sat, Aug 23, 2008 at 6:00 PM, Benjamin Peterson
[EMAIL PROTECTED] wrote:

 Benjamin Peterson [EMAIL PROTECTED] added the comment:

 Those changes are great; thanks for the review! Are you happy enough
 with it to let me apply?


Yep.

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-24 Thread Benjamin Peterson 

Benjamin Peterson [EMAIL PROTECTED] added the comment:

Ok. Applied in r66013.

--
resolution:  - fixed
status: open - closed

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-23 Thread Brett Cannon 

Brett Cannon [EMAIL PROTECTED] added the comment:

I reviewed the patch and made some changes (which I uploaded). Mostly
changed the punctuation of the warning, made sure that PyErr_WarnPy3k()
was used for all cases, and simplified the code for the test.

Assigning to Benjamin for him to decide if he likes the changes to his
patch (which I probably should have done in Rietveld in hindsight =).

--
assignee:  - benjamin.peterson
keywords:  -26backport
type:  - behavior
Added file: http://bugs.python.org/file11232/slice_warnings.diff

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-23 Thread Benjamin Peterson 

Benjamin Peterson [EMAIL PROTECTED] added the comment:

Those changes are great; thanks for the review! Are you happy enough
with it to let me apply?

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-21 Thread Brett Cannon 

Changes by Brett Cannon [EMAIL PROTECTED]:


--
priority: critical - release blocker

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-21 Thread Brett Cannon 

Changes by Brett Cannon [EMAIL PROTECTED]:


--
keywords: +needs review

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-07-01 Thread Georg Brandl 

Changes by Georg Brandl [EMAIL PROTECTED]:


--
assignee: georg.brandl - 

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-03-21 Thread Benjamin Peterson 

Benjamin Peterson [EMAIL PROTECTED] added the comment:

Here's a patch for that. It gives warnings on use of __getslice__,
__delslice__, and __setslice__ and includes tests.
But
it only works on new style classes. I don't think this is a big problem
because users will see the warnings when they switch their classes to
new-style.

--
keywords: +patch
nosy: +benjamin.peterson
Added file: http://bugs.python.org/file9808/slice_methods_py3kwarn.patch

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-03-17 Thread Brett Cannon 

New submission from Brett Cannon [EMAIL PROTECTED]:

Using any of the slicing methods (e.g., __getslice__) should raise a
Py3K warning.

--
components: Interpreter Core
keywords: 26backport
messages: 63721
nosy: brett.cannon
priority: immediate
severity: normal
status: open
title: Using __(get|set|del)slice__ needs a Py3K warning
versions: Python 2.6

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-03-17 Thread Brett Cannon 

Changes by Brett Cannon [EMAIL PROTECTED]:


--
priority: immediate - urgent

__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com