[issue23706] pathlib.Path.write_text should include a newline argument

[Inada Naoki]

Inada Naoki  added the comment:

Thank you

--
nosy: +methane
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[miss-islington]

miss-islington  added the comment:


New changeset 5f227413400c4dfdba210cc0f8c9305421638bc1 by Максим in branch 
'master':
bpo-23706: Add newline parameter to pathlib.Path.write_text (GH-22420) 
(GH-22420)
https://github.com/python/cpython/commit/5f227413400c4dfdba210cc0f8c9305421638bc1


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Maxim Burov]

Maxim Burov  added the comment:

CLA signed now and PR is ready :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It should work exactly as the newline argument of open(). Anything else would 
be surprising.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Maxim Burov]

Maxim Burov  added the comment:

For the newline parameter, what is the expected behaviour? To work as newline 
from io.open() which supports only so called "legal" newlines which are: None, 
'', '\n', '\r', and '\r\n', or to allow users use any sequence as newline hence 
do replacing before passing text to io.open()?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Maxim Burov]

Change by Maxim Burov :


--
keywords: +patch
nosy: +maksvenberv
nosy_count: 5.0 -> 6.0
pull_requests: +21458
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/22420

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +easy
stage:  -> needs patch
versions: +Python 3.10 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Tzu-ping Chung]

Change by Tzu-ping Chung :


--
nosy: +uranusjr

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Thrlwiti]

Change by Thrlwiti :


--
nosy: +THRlWiTi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

It seems a similar API was suggested in the initial stages at 
https://bugs.python.org/issue20218#msg209017 . But looking at the reference 
library in the comment https://github.com/jaraco/path.py I think it's more 
about converting newlines in the given text with respect to the platform 
instead of adding one at the end.

Thanks

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Ugra Dániel]

New submission from Ugra Dániel:

The new pathlib.Path [read|write]_[binary|text] methods will be very useful, 
one thing I miss badly is the newline argument for write_text.

In some cases text files need a specific line ending (independent from the 
platform the code is being executed on.) In my mind this is analogous to 
passing an explicit encoding argument.

Of course, one can always use built-in open for this scenario. It would be a 
nice addition anyway :)

--
components: Library (Lib)
messages: 238498
nosy: daniel.ugra
priority: normal
severity: normal
status: open
title: pathlib.Path.write_text should include a newline argument
type: enhancement
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23706
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23706] pathlib.Path.write_text should include a newline argument

[Ned Deily]

Changes by Ned Deily n...@acm.org:


--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23706
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com