[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer
Roundup Robot added the comment: New changeset d478a2a5738a by Victor Stinner in branch 'default': Issue #23709, #23001: ossaudiodev now uses Py_ssize_t for sizes instead of int https://hg.python.org/cpython/rev/d478a2a5738a -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer
Changes by STINNER Victor victor.stin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer
Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +neologix, pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer
STINNER Victor added the comment: I commited changes to use _Py_read() and _Py_write(). I attach an updated patch to use Py_ssize_t instead of int, and to use Py_buffer instead of char*. -- Added file: http://bugs.python.org/file38571/ossaudiodev-py_buffer.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer
Roundup Robot added the comment: New changeset d564695b67bb by Victor Stinner in branch 'default': Issue #23709: The ossaudiodev module now retries read/write when interrupted by https://hg.python.org/cpython/rev/d564695b67bb -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer
STINNER Victor added the comment: Oh, I forgot to mention the advantage of using _Py_read() and _Py_write(): they retry read/write when interrupted by a signal, to support the PEP 475. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer
Changes by STINNER Victor victor.stin...@gmail.com: -- dependencies: +PEP 475: Add _Py_read() and _Py_write() functions ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer
New submission from STINNER Victor: Attached patch enhances ossaudiodev to support buffer larger than 2 GB (replace the C int type with C Py_ssize_t). It uses the new _Py_read() and _Py_write() functions added in the issue #23708 with the Py_buffer API. By the way, I don't understand the purpose of the input and output counters (icount and ocount fields of the oss_audio_t structure), they don't look to be used?! -- files: ossaudiodev.patch keywords: patch messages: 238516 nosy: haypo priority: normal severity: normal status: open title: Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer versions: Python 3.5 Added file: http://bugs.python.org/file38559/ossaudiodev.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23709 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
