[issue24125] Fix for #23865 breaks docutils

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24125] Fix for #23865 breaks docutils

[Roundup Robot]

Roundup Robot added the comment:

New changeset fe340c2a220e by Serhiy Storchaka in branch '2.7':
Issue #24125: Saved error's line and column numbers when an error is occured
https://hg.python.org/cpython/rev/fe340c2a220e

New changeset 7f8cd879687b by Serhiy Storchaka in branch '3.4':
Issue #24125: Saved error's line and column numbers when an error is occured
https://hg.python.org/cpython/rev/7f8cd879687b

New changeset 1fb83fa2cdef by Serhiy Storchaka in branch 'default':
Issue #24125: Saved error's line and column numbers when an error is occured
https://hg.python.org/cpython/rev/1fb83fa2cdef

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24125] Fix for #23865 breaks docutils

[Dmitry Shachnev]

Dmitry Shachnev added the comment:

The patch fixes the issue, thanks Serhiy!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24125] Fix for #23865 breaks docutils

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a patch that keeps error column and line after closing ExpatParser if 
error was occurred.

--
keywords: +patch
stage:  -> patch review
type:  -> behavior
versions: +Python 3.5
Added file: http://bugs.python.org/file39290/expatreader_keep_col_line.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24125] Fix for #23865 breaks docutils

[Dmitry Shachnev]

Changes by Dmitry Shachnev :


--
nosy: +larry
versions: +Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24125] Fix for #23865 breaks docutils

[Matthias Klose]

Changes by Matthias Klose :


--
nosy: +benjamin.peterson
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24125] Fix for #23865 breaks docutils

[Dmitry Shachnev]

New submission from Dmitry Shachnev:

Fix for issue #23865 (i.e. https://hg.python.org/cpython/rev/f7ddec2e9e93 in 
2.7 branch) introduced a change for xml.sax.expatreader.ExpatParser class that 
makes its close() method delete _parser object.

This breaks docutils, which handles exceptions in parse() and tries to use 
getColumnNumber() after it fails. The log is available here: 
.

I believe that particular chunk should be reverted.

--
components: Library (Lib)
messages: 242579
nosy: doko, goodger, mitya57, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Fix for #23865 breaks docutils
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com