[issue24348] incorrect decref in C OrderedDict

[Eric Snow]

Changes by Eric Snow :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24348] incorrect decref in C OrderedDict

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8631b88c23f6 by Eric Snow in branch '3.5':
Issue #24348: Drop superfluous increfs/decrefs.
https://hg.python.org/cpython/rev/8631b88c23f6

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24348] incorrect decref in C OrderedDict

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24348] incorrect decref in C OrderedDict

[Yury Selivanov]

Changes by Yury Selivanov :


--
nosy: +yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24348] incorrect decref in C OrderedDict

[Eric Snow]

New submission from Eric Snow:

(from msg244575 in issue16991)

crash-2.py is due to the fact that _PyDict_Pop() deletes a reference
to 'key' in _odict_popkey().

The INCREF(key) in popitem should take place before calling _odict_popkey().


Again, I don't see the point of INCREF/DECREF *inside* of _odict_popkey().

--
assignee: eric.snow
components: Library (Lib)
files: crash-2.py
messages: 244598
nosy: eric.snow, skrah
priority: release blocker
severity: normal
stage: needs patch
status: open
title: incorrect decref in C OrderedDict
type: crash
versions: Python 3.5, Python 3.6
Added file: http://bugs.python.org/file39589/crash-2.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com