[issue24381] Got warning when compiling ffi.c on Mac

[Ned Deily]

Ned Deily added the comment:

Thank you for the patch!  Now fixed in the bundled versions of libffi for OS X.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2b089035a453 by Ned Deily in branch '3.5':
Issue #24381: Avoid unused function warning when building bundled macOS libffi.
https://hg.python.org/cpython/rev/2b089035a453

New changeset c60d41590054 by Ned Deily in branch '3.6':
Issue #24381: merge from 3.5
https://hg.python.org/cpython/rev/c60d41590054

New changeset 59838bede1de by Ned Deily in branch 'default':
Issue #24381: merge from 3.6
https://hg.python.org/cpython/rev/59838bede1de

New changeset cca20d28f348 by Ned Deily in branch '2.7':
Issue #24381: Avoid unused function warning when building bundled macOS libffi.
https://hg.python.org/cpython/rev/cca20d28f348

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

@zach.ware so in this case, we could merge the patch in 3.6 & 3.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[Zachary Ware]

Zachary Ware added the comment:

Correction: #27979 is unrelated to Modules/_ctypes/libffi_osx.  A hypothetical 
(at this point) removal of libffi_osx will be a separate issue.  I think it's 
probably worthwhile to fix this issue.

--
nosy: +zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

@victor

There are two issues.

1. The bundled version of CFFI is just outdated
2. There is an issue for the removal of libffi_osx 
(http://bugs.python.org/issue27979)

so, we can fix the bundled libcffi or close this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

of course, I will do it. Thank for your review

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[STINNER Victor]

STINNER Victor added the comment:

Modules/_ctypes/libffi_osx/ffi.c comes from libffi, can you please propose a 
bugfix upstream?

* https://sourceware.org/libffi/
* https://github.com/libffi/libffi

I'm not sure where is the upstream.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[Stéphane Wirtel]

Stéphane Wirtel added the comment:

I have reviewed the patch, the first "#if defined" was not complete.

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[Stéphane Wirtel]

Changes by Stéphane Wirtel :


--
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24381] Got warning when compiling ffi.c on Mac

[Vajrasky Kok]

New submission from Vajrasky Kok:

On my OS X Yosemite 10.10.3, I got this warning when compiling 
Modules/_ctypes/libffi_osx/ffi.c.

gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes 
-Werror=declaration-after-statement -I_ctypes/darwin 
-I/Users/sky/Code/python/cpython/Modules/_ctypes/libffi_osx/include 
-I/Users/sky/Code/python/cpython/Modules/_ctypes/libffi_osx/powerpc -I./Include 
-I. -IInclude -I/usr/local/include -I/Users/sky/Code/python/cpython/Include 
-I/Users/sky/Code/python/cpython -c 
/Users/sky/Code/python/cpython/Modules/_ctypes/libffi_osx/ffi.c -o 
build/temp.macosx-10.9-x86_64-3.6-pydebug/Users/sky/Code/python/cpython/Modules/_ctypes/libffi_osx/ffi.o
 -DMACOSX
/Users/sky/Code/python/cpython/Modules/_ctypes/libffi_osx/ffi.c:108:1: warning: 
unused function 'struct_on_stack' [-Wunused-function]
struct_on_stack(
^
1 warning generated.

Here is the patch that I think can fix the warning.

--
components: Macintosh
files: fix_ffi_compile_warning.patch
keywords: patch
messages: 244825
nosy: ned.deily, ronaldoussoren, vajrasky
priority: normal
severity: normal
status: open
title: Got warning when compiling ffi.c on Mac
versions: Python 3.5, Python 3.6
Added file: http://bugs.python.org/file39618/fix_ffi_compile_warning.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com